Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add a CI job to test cluster upgrading, and fix bug of testcases_run.sh #11458

Merged

Conversation

tmurakam
Copy link
Contributor

@tmurakam tmurakam commented Aug 18, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
This adds a packet_ubuntu22-calico-all-in-one-upgrade job to test cluster upgrading. This is needed to test #11352

Also this fixes a bug in testcases_run.sh which does not checkout the latest (target) commit before upgrading.
(Partially revert the #11173)

Which issue(s) this PR fixes:

Fixes #11173

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 18, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @tmurakam. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@tmurakam: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmurakam tmurakam changed the title [WIP][CI] Add a CI job to test cluster upgrading [CI] Add a CI job to test cluster upgrading Aug 18, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2024
@tmurakam tmurakam changed the title [CI] Add a CI job to test cluster upgrading [CI] Add a CI job to test cluster upgrading, and fix bug of testcases_run.sh Aug 18, 2024
@VannTen
Copy link
Contributor

VannTen commented Aug 27, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2024
@yankay yankay mentioned this pull request Aug 29, 2024
@yankay yankay closed this Aug 29, 2024
@yankay yankay reopened this Aug 29, 2024
@tmurakam tmurakam force-pushed the feature/add-upgrade-ci-job branch 2 times, most recently from 66ba3a2 to 9ee106c Compare August 29, 2024 03:55
Need to git checkout ${CI_COMMIT_SHA} before running upgrade playbook (revert kubernetes-sigs#11173 partially)
Add a packet_ubuntu22-calico-all-in-one-upgrade job
@VannTen
Copy link
Contributor

VannTen commented Aug 29, 2024

/lgtm
/assign @yankay

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@VannTen
Copy link
Contributor

VannTen commented Aug 29, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmurakam, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 60b323b into kubernetes-sigs:master Aug 29, 2024
40 checks passed
@tmurakam tmurakam deleted the feature/add-upgrade-ci-job branch September 3, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants