Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update CNI to v1.2.0 #10101

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore(deps): update CNI to v1.2.0 #10101

merged 1 commit into from
Apr 29, 2024

Conversation

Icarus9913
Copy link
Contributor

@Icarus9913 Icarus9913 commented Apr 28, 2024 •
edited
Loading

The CNI SDK function 'skel.PluginMain' was deprecated, we need to use the new function 'skel.PluginMainFuncs' to replace it.

close #9992
close #10102

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@Icarus9913 Icarus9913 requested a review from a team as a code owner April 28, 2024 01:49
@Icarus9913 Icarus9913 requested review from michaelbeaumont, slonka and lobkovilya and removed request for a team April 28, 2024 01:49
@Icarus9913
chore(deps): Update CNI to v1.2.0
71d51a0 
The CNI SDK function 'skel.PluginMain' was deprecated, we need to use the new function 'skel.PluginMainFuncs' to replace it.

Fix kumahq#10102

Signed-off-by: Icarus Wu <icaruswu66@qq.com>
jijiechen
jijiechen reviewed Apr 28, 2024
View reviewed changes
go.mod Show resolved Hide resolved
@slonka slonka changed the title chore(deps): Update CNI to v1.2.0 chore(deps): update CNI to v1.2.0 Apr 29, 2024
michaelbeaumont
michaelbeaumont approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukidzi lukidzi merged commit d69ec26 into kumahq:master Apr 29, 2024
16 of 17 checks passed
@jakubdyszkiewicz jakubdyszkiewicz mentioned this pull request Apr 30, 2024
Merged
5 tasks
lobkovilya pushed a commit that referenced this pull request May 15, 2024
@Icarus9913 @lobkovilya
chore(deps): update CNI to v1.2.0 (#10101)
4cf32e8 
Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@BrewTestBot BrewTestBot mentioned this pull request Jun 24, 2024
Merged
@Icarus9913 Icarus9913 deleted the chore/wk/upgrade-cni branch July 2, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jijiechen jijiechen jijiechen left review comments

@slonka slonka slonka approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CNI to v1.2.0
5 participants
@Icarus9913 @jijiechen @michaelbeaumont @slonka @lukidzi