Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge features branch to prafful branch #22

Merged
merged 20 commits into from
Dec 9, 2023
Merged

Conversation

kushwahramkumar2003
Copy link
Owner

Add Create, Delete Quiz feature and also add Add new Question and delete Question features added.

kushwahramkumar2003 and others added 20 commits November 19, 2023 15:34
Merge ram branch to features branch
Merge pull request #20 from kushwahramkumar2003/features
@@ -5,7 +5,7 @@
MONGODB_URL: process.env.MONGODB_URL || "mongodb://localhost:27017/quiz-app",
PORT: process.env.PORT || 3001,

JWT_SECRET: process.env.JWT_SECRET,
JWT_SECRET: process.env.JWT_SECRET || "thisisasecret",

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

The hard-coded value "thisisasecret" is used as
key
.
The hard-coded value "thisisasecret" is used as
key
.
@@ -54,7 +54,10 @@

const { email, password } = req.body;

let user = await User.findOne({ email }, { email: 1, password: 1, name: 1 });
let user = await User.findOne(
{ email },

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
.
@kushwahramkumar2003 kushwahramkumar2003 merged commit c211045 into Prafful Dec 9, 2023
2 of 3 checks passed
kushwahramkumar2003 added a commit that referenced this pull request Dec 9, 2023
Merge pull request #22 from kushwahramkumar2003/features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant