Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unify nodejs version for building #3332

Merged
merged 2 commits into from
Sep 6, 2024
Merged

feat: Unify nodejs version for building #3332

merged 2 commits into from
Sep 6, 2024

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Sep 5, 2024 •
edited by mrCherry97
Loading

Description

Changes proposed in this pull request:

  • Use one node version
  • remove instalation of nodejs

Related issue(s)

#3298

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2024
@dbadura dbadura changed the title Unify nodejs version for building feat: Unify nodejs version for building Sep 5, 2024
@dbadura dbadura closed this Sep 5, 2024
@dbadura dbadura reopened this Sep 5, 2024
mrCherry97
mrCherry97 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove old alpine image from test-infra after merge

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 6, 2024
@mrCherry97 mrCherry97 merged commit 424dee1 into kyma-project:main Sep 6, 2024
15 checks passed
@dbadura dbadura deleted the use-one-node-image branch September 6, 2024 08:17
@dbadura
Copy link
Contributor Author

dbadura commented Sep 6, 2024

Here is PR with removal of old alpines: kyma-project/test-infra#11805

@dbadura dbadura mentioned this pull request Sep 12, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbadura @mrCherry97 @kyma-bot