Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unify nodejs version for building #3332

Merged
merged 2 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/busola-kyma-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ on:
- "package.json"
- "Makefile"
- "Dockerfile.kyma"
- "Dockerfile.local.kyma"

pull_request_target:
types: [opened, edited, synchronize, reopened, ready_for_review]
paths:
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# ---- Base Alpine with Node ----
FROM alpine:3.20.2 AS builder
FROM node:20.17-alpine3.20 AS builder
ARG default_tag

# Install global dependencies
RUN apk update && \
apk upgrade && \
apk add --no-cache make nodejs npm yq
apk add --no-cache make yq

WORKDIR /app

Expand Down
6 changes: 3 additions & 3 deletions Dockerfile.kyma
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# ---- Base Alpine with Node ----
FROM alpine:3.20.2 AS builder
FROM node:20.17-alpine3.20 AS builder
ARG default_tag

# Install global dependencies
RUN apk update && \
apk upgrade && \
apk add --no-cache make nodejs npm yq
apk add --no-cache make yq

WORKDIR /app

Expand All @@ -21,7 +21,7 @@ RUN yq -i '.version = "'${default_tag}'"' public/version.yaml && \
RUN npm run build:docker

# ---- Environments Configuration ----
FROM node:22.7.0-alpine3.19 as configuration
FROM node:20.17-alpine3.20 as configuration
#RUN apk add make
WORKDIR /kyma

Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.local
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# this is a Dockerfile for single deployment app - both backend and frontends

# ---- Base Alpine with Node ----
FROM alpine:3.20.2 AS builder
FROM node:20.17-alpine3.20 AS builder
ARG default_tag

RUN apk update && \
apk upgrade && \
apk add --no-cache --update make nodejs npm yq
apk add --no-cache make yq

WORKDIR /app

Expand Down
6 changes: 3 additions & 3 deletions Dockerfile.local.kyma
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# this is a Dockerfile for single deployment app - both backend and frontends

# ---- Base Alpine with Node ----
FROM alpine:3.20.2 AS builder
FROM node:20.17-alpine3.20 AS builder
ARG default_tag

RUN apk update && \
apk upgrade && \
apk add --no-cache --update make nodejs npm yq
apk add --no-cache make yq

WORKDIR /app

Expand All @@ -25,7 +25,7 @@ RUN npm run build:docker
RUN cd /app/backend && npm run build

# ---- Environments Configuration ----
FROM node:22.7.0-alpine3.19 as configuration
FROM node:20.17-alpine3.20 AS configuration
#RUN apk add make
WORKDIR /kyma

Expand Down
Loading