Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust reset.css #3524

Merged
merged 1 commit into from
Dec 10, 2024
Merged

adjust reset.css #3524

merged 1 commit into from
Dec 10, 2024

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Dec 9, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • removed unneeded properties from reset.css
  • minor adjustments

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2024
@chriskari chriskari changed the title minor adjustments adjust reset.css Dec 9, 2024
@chriskari chriskari mentioned this pull request Dec 9, 2024
Open
@mrCherry97 mrCherry97 self-assigned this Dec 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 10, 2024
@mrCherry97 mrCherry97 merged commit 3517ff7 into kyma-project:ui5-migrate-v2 Dec 10, 2024
26 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriskari @mrCherry97 @kyma-bot