generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD structure prepared #24
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
48784c7
CRD renamed
akgalwas 1b12bcc
Fields added
akgalwas 761dbf9
Fields adjusted
akgalwas 589d9fa
CRD defined as cluster scoped
akgalwas fc0da37
Merge remote-tracking branch 'upstream/main' into define-crd
akgalwas ba224f3
Discussion results
akgalwas ab196eb
Update clusterinventory_v1_gardenercluster.yaml
akgalwas 726c03a
Update clusterinventory_v1_gardenercluster.yaml
akgalwas 3859d91
Merge remote-tracking branch 'upstream/main' into define-crd
akgalwas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
/* | ||
Copyright 2023. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package v1 | ||
|
||
import ( | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
) | ||
|
||
//+kubebuilder:object:root=true | ||
//+kubebuilder:subresource:status | ||
|
||
// GardenerCluster is the Schema for the clusters API | ||
type GardenerCluster struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
||
Spec GardenerClusterSpec `json:"spec"` | ||
Status GardenerClusterStatus `json:"status,omitempty"` | ||
} | ||
|
||
//+kubebuilder:object:root=true | ||
|
||
// GardenerClusterList contains a list of GardenerCluster | ||
type GardenerClusterList struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ListMeta `json:"metadata,omitempty"` | ||
Items []GardenerCluster `json:"items"` | ||
} | ||
|
||
// GardenerClusterSpec defines the desired state of GardenerCluster | ||
type GardenerClusterSpec struct { | ||
Kubeconfig Kubeconfig `json:"kubeconfig"` | ||
} | ||
|
||
// Kubeconfig defines the desired kubeconfig location | ||
type Kubeconfig struct { | ||
Secret Secret `json:"secret"` | ||
} | ||
|
||
// SecretKeyRef defines the location, and structure of the secret containing kubeconfig | ||
type Secret struct { | ||
Name string `json:"name"` | ||
Namespace string `json:"namespace"` | ||
Key string `json:"key"` | ||
} | ||
|
||
type State string | ||
|
||
const ( | ||
ReadyState State = "Ready" | ||
ProcessingState State = "Processing" | ||
ErrorState State = "Error" | ||
DeletingState State = "Deleting" | ||
) | ||
|
||
// GardenerClusterStatus defines the observed state of GardenerCluster | ||
type GardenerClusterStatus struct { | ||
// State signifies current state of Gardener Cluster. | ||
// Value can be one of ("Ready", "Processing", "Error", "Deleting"). | ||
State State `json:"state,omitempty"` | ||
|
||
Disper marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// List of status conditions to indicate the status of a ServiceInstance. | ||
// +optional | ||
// +listType=map | ||
// +listMapKey=type | ||
Conditions []metav1.Condition `json:"conditions,omitempty"` | ||
} | ||
|
||
func init() { | ||
SchemeBuilder.Register(&GardenerCluster{}, &GardenerClusterList{}) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,49 +0,0 @@ | ||
--- | ||
apiVersion: apiextensions.k8s.io/v1 | ||
kind: CustomResourceDefinition | ||
metadata: | ||
annotations: | ||
controller-gen.kubebuilder.io/version: v0.12.0 | ||
name: clusterinventories.infrastructuremanager.kyma-project.io | ||
spec: | ||
group: infrastructuremanager.kyma-project.io | ||
names: | ||
kind: infrastructuremanager | ||
listKind: infrastructuremanagerList | ||
plural: clusterinventories | ||
singular: infrastructuremanager | ||
scope: Namespaced | ||
versions: | ||
- name: v1 | ||
schema: | ||
openAPIV3Schema: | ||
description: infrastructuremanager is the Schema for the clusterinventories API | ||
properties: | ||
apiVersion: | ||
description: 'APIVersion defines the versioned schema of this representation | ||
of an object. Servers should convert recognized schemas to the latest | ||
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources' | ||
type: string | ||
kind: | ||
description: 'Kind is a string value representing the REST resource this | ||
object represents. Servers may infer this from the endpoint the client | ||
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds' | ||
type: string | ||
metadata: | ||
type: object | ||
spec: | ||
description: infrastructuremanagerSpec defines the desired state of infrastructuremanager | ||
properties: | ||
foo: | ||
description: Foo is an example field of infrastructuremanager. Edit infrastructuremanager_types.go | ||
to remove/update | ||
type: string | ||
type: object | ||
status: | ||
description: infrastructuremanagerStatus defines the observed state of infrastructuremanager | ||
type: object | ||
type: object | ||
served: true | ||
storage: true | ||
subresources: | ||
status: {} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should anything else be adjusted (or re-scaffolded ?) after this change? It's just not clear to me how this setting is exactly used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did run
make test
and nothing was changed. I assume the change in CRD is enough.