Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache error #63

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix cache error #63

merged 1 commit into from
Nov 13, 2023

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Nov 13, 2023

Description

Fix cache error.

Changes proposed in this pull request:

  • fix cache error
  • code cleanup

@m00g3n m00g3n requested a review from a team as a code owner November 13, 2023 10:27
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2023
@kyma-bot kyma-bot merged commit dbdd724 into kyma-project:main Nov 13, 2023
5 checks passed
func (controller *GardenerClusterController) updateExistingSecret(ctx context.Context, kubeconfig string, cluster *imv1.GardenerCluster, existingSecret *corev1.Secret, lastSyncTime time.Time) error {
if existingSecret.Data == nil {
existingSecret.Data = map[string][]byte{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment for myself to ask about that line offline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants