Skip to content

Commit

Permalink
Simplify fork_choice runner a bit
Browse files Browse the repository at this point in the history
  • Loading branch information
MegaRedHand committed Mar 14, 2024
1 parent 3344ce4 commit 3001a1c
Showing 1 changed file with 1 addition and 69 deletions.
70 changes: 1 addition & 69 deletions test/spec/runners/fork_choice.ex
Original file line number Diff line number Diff line change
Expand Up @@ -16,68 +16,6 @@ defmodule ForkChoiceTestRunner do

use HardForkAliasInjection

@disabled_on_block_cases [
# "basic",
# "incompatible_justification_update_end_of_epoch",
# "incompatible_justification_update_start_of_epoch",
# "justification_update_beginning_of_epoch",
# "justification_update_end_of_epoch",
# "justification_withholding",
# "justification_withholding_reverse_order",
# "justified_update_always_if_better",
# "justified_update_monotonic",
# "justified_update_not_realized_finality",
# "new_finalized_slot_is_justified_checkpoint_ancestor",
# "not_pull_up_current_epoch_block",
# "on_block_bad_parent_root",
# "on_block_before_finalized",
# "on_block_checkpoints",
# "on_block_finalized_skip_slots",
# "on_block_finalized_skip_slots_not_in_skip_chain",
# "on_block_future_block",
# "proposer_boost",
# "proposer_boost_root_same_slot_untimely_block",
# "pull_up_on_tick",
# "pull_up_past_epoch_block"
]

@disabled_ex_ante_cases [
# "ex_ante_attestations_is_greater_than_proposer_boost_with_boost",
# "ex_ante_sandwich_with_boost_not_sufficient",
# "ex_ante_sandwich_with_honest_attestation",
# "ex_ante_sandwich_without_attestations",
# "ex_ante_vanilla"
]

@disabled_get_head_cases [
# "chain_no_attestations",
# "discard_equivocations_on_attester_slashing",
# "discard_equivocations_slashed_validator_censoring",
# "filtered_block_tree",
# "genesis",
# "proposer_boost_correct_head",
# "shorter_chain_but_heavier_weight",
# "split_tie_breaker_no_attestations",
# "voting_source_beyond_two_epoch",
# "voting_source_within_two_epoch"
]

@disabled_reorg_cases [
# "delayed_justification_current_epoch",
# "delayed_justification_previous_epoch",
# "include_votes_another_empty_chain_with_enough_ffg_votes_current_epoch",
# "include_votes_another_empty_chain_with_enough_ffg_votes_previous_epoch",
# "include_votes_another_empty_chain_without_enough_ffg_votes_current_epoch",
# "simple_attempted_reorg_delayed_justification_current_epoch",
# "simple_attempted_reorg_delayed_justification_previous_epoch",
# "simple_attempted_reorg_without_enough_ffg_votes"
]

@disabled_withholding_cases [
# "withholding_attack",
# "withholding_attack_unviable_honest_chain"
]

# TODO: implement blob checks
@disabled_deneb [
"invalid_data_unavailable",
Expand All @@ -87,13 +25,7 @@ defmodule ForkChoiceTestRunner do
]

@impl TestRunner
def skip?(%SpecTestCase{fork: "capella", case: testcase}) do
Enum.member?(@disabled_on_block_cases, testcase) or
Enum.member?(@disabled_ex_ante_cases, testcase) or
Enum.member?(@disabled_get_head_cases, testcase) or
Enum.member?(@disabled_reorg_cases, testcase) or
Enum.member?(@disabled_withholding_cases, testcase)
end
def skip?(%SpecTestCase{fork: "capella"}), do: false

def skip?(%SpecTestCase{fork: "deneb", case: testcase}) do
Enum.member?(@disabled_deneb, testcase)
Expand Down

0 comments on commit 3001a1c

Please sign in to comment.