Adds Makefile and env.sh #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JulianGCalderon
force-pushed
the
makefile
branch
3 times, most recently
from
607639a to
5bb7a80
Compare
JulianGCalderon
requested review from
edg-l,
igaray,
azteca1998,
fmoletta and
pefontana
as code owners
edg-l
approved these changes
Jul 16, 2024
pefontana
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --all-features flag was deliberately left out of the make rules as the benchmark feature it's currently being worked on in #13 (and it does not compile in main). Before merging that PR, it must be added to the Makefile.
I left out some Makefile rules to keep it simple, but I can add them if they are desired:
make runtime: Clones cairo native and compiles the runtime librarymake check-env: Checks that all needed env variables are set. If I add this then there is probably no need for printing a remainder inenv.sh