Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TransactionInfo tets #35

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Add TransactionInfo tets #35

merged 5 commits into from
Aug 12, 2024

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Jul 24, 2024 •
edited
Loading

Refers to: #34
This PR adds tests checking some TransactionInfo fileds:

  • da_gas
  • state_changes_for_fee
  • actual_resources.starknet_resources
  • revert_error

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

✅ Code is now correctly formatted.

@FrancoGiachetta FrancoGiachetta marked this pull request as ready for review July 25, 2024 21:39
pefontana
pefontana approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @FrancoGiachetta !

@pefontana pefontana linked an issue Jul 29, 2024 that may be closed by this pull request
[TEST] Assert TransactionExecutionInfo #34
Closed
JulianGCalderon
JulianGCalderon approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pefontana pefontana added this pull request to the merge queue Aug 12, 2024
@pefontana pefontana mentioned this pull request Aug 12, 2024
Closed
Merged via the queue into main with commit 7b44aff Aug 12, 2024
4 checks passed
@pefontana pefontana mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pefontana pefontana pefontana approved these changes

@JulianGCalderon JulianGCalderon JulianGCalderon approved these changes

@edg-l edg-l Awaiting requested review from edg-l edg-l is a code owner

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@azteca1998 azteca1998 Awaiting requested review from azteca1998 azteca1998 is a code owner

@fmoletta fmoletta Awaiting requested review from fmoletta fmoletta is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEST] Assert TransactionExecutionInfo
3 participants
@FrancoGiachetta @JulianGCalderon @pefontana