-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate no-npe EEA generator #168
Conversation
1ee3d4f
to
77a4946
Compare
Thank You! I'm personally excited to see this ... rejuvenation of this project! I would love to hear from any of the people who were active here in the past, if they are all for this as well, or anyone got any sort of objections? I doubt it - so just asking for good community stewardship! Paging, looking at https://github.com/lastnpe/eclipse-null-eea-augments/graphs/contributors and https://github.com/orgs/lastnpe/people, e.g. @J-N-K and @rPraml and @focbenz and @maggu2810 and @ctron
At least my browser is crushing on the Files changed tab... 😄 I don't suppose that I could motivate you to break this up, at least a little bit? E.g. along the lines of something like, just a thought:
I would love to understand, but still don't really, how - but let's further discuss this there, not here! (Not holding this up on that.) |
Does that mean EEAs for |
@J-N-K I have no strong feelings about this. In https://github.com/vegardit/no-npe/ I maintain EEAs for the javax and the jakarta version. But I think we should generally come up with some guideline which frameworks/libraries we maintain and when to drop them. After all one can always reference the already published artifacts like https://central.sonatype.com/artifact/org.lastnpe.eea/servlet-api-eea/2.4.0 even if they libs are removed from latest releases. Since javax.servlet was superseded by jakarta.servlet 4 years ago it might be a good point in time to drop it with a new upcoming major release of lastNPE. |
Karaf - being one of the most popular OSGi frameworks - still depends on PaxWeb 8 / Jetty 9.x and that requires |
Re. More generally, @sebthom do you want to further break up what's on this (too?) massive PR, so that it's easier to iteratively review more batches? I'm still reluctant to LGTM this for 5000+ files changed which I'm struggling to (easily) review. |
it's fine with me.
Yes, I see how we can break it up further. We are already down 10 commits :-) |
@vorburger I stripped down the PR and will submit the other changes in separate PRs. With these changes you should be able to run The included CI job validates EEAs for each commit/PR and will create/update a Maven snapshot repository when run on the main branch |
801e4ac
to
3ef257b
Compare
Signed-off-by: sebthom <sebthom@users.noreply.github.com>
Signed-off-by: sebthom <sebthom@users.noreply.github.com>
Motivated by related discussions during review of #168. Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Motivated by related discussions during review of #168. Signed-off-by: Michael Vorburger <mike@vorburger.ch>
With this PR Vegard IT GmbH https://vegardit.com/ contributes the code of it's EEA Generator/Validator hosted at https://github.com/vegardit/no-npe to the LastNPE project.
The following changes are made to the project:
com.vegardit.no_npe.eea_generator
EEAGenerator is migrated to the lastnpe project under the root packageorg.lastnpe.eea.generator
You can see how the generated EEA jar files will look like at https://github.com/sebthom/eclipse-null-eea-augments/tree/mvn-snapshots-repo/org/lastnpe/eea
This PR solves #16 #161