Updates for GNSS API assistance usage #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lemrey This PR touches many components, but I'm not able to add reviewers. Would be nice to get reviews from some code owners as well. |
tokangas
commented
Jun 16, 2023
|
@tokangas could you try to add reviewers now? |
tokangas
force-pushed
the
qzss_assistance_support
branch
from
9651ba3
to
0a0dffa
Compare
|
I'll continue with this after my summer vacation. I have been working on adding support for QZSS assistance with nRF Cloud, but there are some things which need to be clarified with the cloud side. |
tokangas
force-pushed
the
qzss_assistance_support
branch
from
9271a93
to
dc62001
Compare
tokangas
force-pushed
the
qzss_assistance_support
branch
2 times, most recently
from
50a8597
to
0a1c70d
Compare
Updated because of GNSS API assistance changes. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Updated because of GNSS API assistance changes. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Updated because of GNSS API assistance changes. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
tokangas
force-pushed
the
qzss_assistance_support
branch
from
0a1c70d
to
ead372b
Compare
|
The PR is now ready for review. Also QZSS assistance support is included. |
Updated because of GNSS API assistance changes. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Updated because of GNSS API assistance changes. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Updated because of GNSS API assistance changes. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Updated because of GNSS API assistance changes. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Updated because of GNSS API assistance changes. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Updated because of GNSS API assistance changes. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
tokangas
force-pushed
the
qzss_assistance_support
branch
from
ead372b
to
b96d0e7
Compare
MarkusLassila
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Looks good from SLM perspective. We will run our GNSS test against the main PR.
@tokangas: Any opinion whether we should add additional AT-command support to SLM for the QZSS satellites?
jayteemo
approved these changes
Aug 14, 2023
tokangas
force-pushed
the
qzss_assistance_support
branch
from
b96d0e7
to
70bc174
Compare
@MarkusLassila There are only a few QZSS related options in the API, and those have been present already earlier.
I think that's all. Probably there's no need to have AT commands for those in SLM, I think. |
Implemented support for QZSS assistance. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Implemented support for QZSS assistance. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Added support for QZSS assistance. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
Added support for QZSS assistance. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
tokangas
force-pushed
the
qzss_assistance_support
branch
from
70bc174
to
4a80d7d
Compare
trantanen
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates GNSS API usage for multi-constellation assistance support.
Currently, the functionality remains as it was, i.e. only GPS assistance is used. QZSS assistance support with nRF Cloud will still be added into this PR.