Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGING TO TEST BRANCH] Use BuildJet runners for eden workflow #882

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

uncleDecart
Copy link
Collaborator

@uncleDecart uncleDecart commented Jul 31, 2023

This commit changes runners of composite test.yml workflow to BuildJet runners. They are more powerful and cheaper that the ones provided by GitHub.

Note that this workflow is used by EVE repository.

Switching to BuildJet runners and using new workflow should reduce time to run tests from 6 hours to approx. 1.5 hours.

However, there are still some tests failing which needs further investigation.

Why [MERGING TO TEST BRANCH]: LF-edge is still setting up billing process for BuildJet, we will merge this once it's done. Right now we can try it out and see if it's working by running action manually. Next step would be to check if changing workflow runners changes them while using composite workflow.

Checklist:

  • [] Eden workflow dispatched manually runs on BuildJet successfully*
  • [] EVE runs test.yml workflow and it uses BuildJet runners
  • some tests are still failing

This commit changes runners of composite `test.yml` workflow to BuildJet
runners. They are more powerful and cheaper that the ones provided by GitHub.

Note that this workflow is used by EVE repository.

Switching to BuildJet runners and using new workflow should reduce time to
run tests from 6 hours to approx. 1.5 hours.

However, there are still some tests failing which needs further investigation

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
@uncleDecart uncleDecart changed the base branch from master to test-buildjet July 31, 2023 08:22
@uncleDecart uncleDecart changed the title [DO NOT MERGE] Use BuildJet runners for eden workflow [MERGING TO TEST BRANCH] Use BuildJet runners for eden workflow Jul 31, 2023
@uncleDecart uncleDecart marked this pull request as ready for review July 31, 2023 08:24
@uncleDecart
Copy link
Collaborator Author

@giggsoff @milan-zededa @yash-zededa

New runners are finally here, but LF-EDGE hasn't finalized bulling yet. So I'm raising this PR to merge it to new test branch I created so we can manually trigger test.yml action and see if it works with BuildJet runners.

To my best knowledge branching this way won't break anything in eden or in eve which is using master branch

@yash-zededa
Copy link
Contributor

LGTM.

@uncleDecart uncleDecart merged commit 1ca91ec into lf-edge:test-buildjet Jul 31, 2023
6 of 9 checks passed
@giggsoff
Copy link
Collaborator

giggsoff commented Jul 31, 2023

Few questions:

  1. Can you please describe somewhere in docs (in new file probably) an information about such runners? Few words or links (specs+how to request them and from where)?
  2. Can we make runners adjustable using variables? It seems someone cannot use them in case of personal fork (correct me if I am wrong).

@uncleDecart
Copy link
Collaborator Author

uncleDecart commented Jul 31, 2023

Runner workflow https://github.com/lf-edge/eden/actions/runs/5712658495

Yeah @giggsoff , you cannot use them in your fork, I believe I can parametrize it with some variable, will do that in master PR

I'll add docs in new PR docs for now are here https://buildjet.com/for-github-actions/docs/getting-started/run-your-first-workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants