Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BuildJet runners for eden workflow #884

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

uncleDecart
Copy link
Collaborator

This commit changes runners of composite test.yml workflow to BuildJet runners. They are more powerful and cheaper that the ones provided by GitHub.

In case somebody would want to run these workflows in their local fork runner and repository to pull eden code from has been parametrized

Note that this workflow is used by EVE repository.

Switching to BuildJet runners and using new workflow should reduce time to run tests from 6 hours to approx. 1.5 hours.

Documentation is available at docs/github-actions.md

However, there are still some tests failing which needs further investigation

@uncleDecart
Copy link
Collaborator Author

uncleDecart commented Aug 1, 2023

@giggsoff @milan-zededa @yash-zededa

This is continuation of #882
Workflow is available here: https://github.com/lf-edge/eden/actions/runs/5712658495

We need to figure out how to change runners in other workflows

@uncleDecart uncleDecart changed the title [DO NOT MERGE] Use BuildJet runners for eden workflow Use BuildJet runners for eden workflow Aug 18, 2023
@uncleDecart
Copy link
Collaborator Author

@giggsoff @milan-zededa @yash-zededa
LF-Edge replied, we can merge this PR and run, I tested it before on branch I created it worked, I'll run it again. I'll be back on 24th of August, but if we need to merge it asap, let's at least wait for successful run on buildjet

Workflow: https://github.com/lf-edge/eden/actions/runs/5904406291

@uncleDecart uncleDecart marked this pull request as ready for review September 26, 2023 15:38
This commit changes runners of composite `test.yml` workflow to BuildJet
runners. They are more powerful and cheaper that the ones provided by GitHub.

In case somebody would want to run these workflows in their local fork runner
and repository to pull eden code they will have to change repository param

Note that this workflow is used by EVE repository.

Switching to BuildJet runners and using new workflow should reduce time to
run tests from 6 hours to approx. 1.5 hours.

Documentation is available at `docs/github-actions.md`

However, there are still some tests failing which needs further investigation

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
@uncleDecart
Copy link
Collaborator Author

Things are looking good with https://github.com/lf-edge/eve/pull/3450/files so please have a look when you have time so that we can merge it

@milan-zededa @yash-zededa

just FYI @giggsoff :)

@yash-zededa
Copy link
Contributor

LGTM

@yash-zededa
Copy link
Contributor

@uncleDecart Could we please merge and release this so that I may make the necessary adjustments in the Eve PR for the new workflows?

@uncleDecart
Copy link
Collaborator Author

@yash-zededa I still need one approving review @eriknordmark , can you approve?

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 901253f into lf-edge:master Sep 28, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants