Use 'defer' to simplify handling of AppNetworkStatus pending flags #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3468 +/- ##
=======================================
Coverage 20.29% 20.30%
=======================================
Files 198 198
Lines 45268 45268
=======================================
+ Hits 9188 9192 +4
+ Misses 35396 35393 -3
+ Partials 684 683 -1 ☔ View full report in Codecov by Sentry. |
rouming
approved these changes
Sep 27, 2023
Currently, we have to remember to set PendingAdd/PendingModify inside AppNetworkStatus to false just before the corresponding handler returns. However, there are few error branches where we forgot to clear the pending flag. This causes zedmanager to just wait and not report the error published inside the AppNetworkStatus. Instead of fixing this case-by-case, let's take advantage of 'defer' to make sure that we will never forget to clear the Pending flag, even if a new branch with return statement is added in the future. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
fix-pending-flag
branch
from
6533038
to
77460c2
Compare
|
Eden failures are not related this PR and not new. For example, we often get onboarding failure due to error: To determine why we are getting frequent failures nowadays, we need output from collect-info. For old eden workflow this was added to eden repo here: lf-edge/eden#874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have to remember to set
PendingAdd/PendingModifyinsideAppNetworkStatusto false just before the corresponding handler returns (to signal completed operation). However, there are few error branches where we forgot to clear the pending flag (e.g. when IP allocation for VIF fails). This causes zedmanager to just wait and not report the error published inside theAppNetworkStatus.Instead of fixing this case-by-case, let's take advantage of
deferto make sure that we will never forget to clear the pending flag, even if a new branch with return statement is added in the future.