Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devmodel add usb #45

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Devmodel add usb #45

merged 2 commits into from
Feb 29, 2024

Conversation

christoph-zededa
Copy link
Contributor

devmodelcommon.proto: Add types for USB devices

Unfortunately I forgot to add these types before and
one commercial controller started using the IDs
13 and 14, therefore we (@rene@github.com and I) decided
to squeeze in these types and increase the IDs for CAN
as they're not used yet.

@christoph-zededa
devmodelcommon.proto: Add types for USB devices
83e6d7b 
Unfortunately I forgot to add these types before and
one commercial controller started using the IDs
13 and 14, therefore we (@rene@github.com and I) decided
to squeeze in these types and increase the IDs for CAN
as they're not used yet.

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
@christoph-zededa
proto: autogenerated protocol files
eb72533 
All changes after the 'make'.

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
@christoph-zededa
Copy link
Contributor Author

Yetus fails:


yetus: proto/evecommon/devmodelcommon.proto#L27
bufcompat:Enum value "13" on enum "PhyIoType" changed name from "PhyIoCAN" to "PhyIoUSBController".
yetus: proto/evecommon/devmodelcommon.proto#L27
buflint:Enum value name "PhyIoUSBController" should be prefixed with "PHY_IO_TYPE_".
yetus: proto/evecommon/devmodelcommon.proto#L27
buflint:Enum value name "PhyIoUSBController" should be UPPER_SNAKE_CASE, such as "PHY_IO_USB_CONTROLLER".
yetus: proto/evecommon/devmodelcommon.proto#L28
bufcompat:Enum value "14" on enum "PhyIoType" changed name from "PhyIoVCAN" to "PhyIoUSBDevice".
yetus: proto/evecommon/devmodelcommon.proto#L28
buflint:Enum value name "PhyIoUSBDevice" should be prefixed with "PHY_IO_TYPE_".
yetus: proto/evecommon/devmodelcommon.proto#L28
buflint:Enum value name "PhyIoUSBDevice" should be UPPER_SNAKE_CASE, such as "PHY_IO_USB_DEVICE".
yetus: proto/evecommon/devmodelcommon.proto#L29
bufcompat:Enum value "15" on enum "PhyIoType" changed name from "PhyIoLCAN" to "PhyIoCAN".

It complains about changing the IDs, which is expected and it complains about UPPER_SNAKE_CASE, but we want to keep the style.

@rene
Copy link
Contributor

rene commented Feb 29, 2024

Yetus fails:


yetus: proto/evecommon/devmodelcommon.proto#L27
bufcompat:Enum value "13" on enum "PhyIoType" changed name from "PhyIoCAN" to "PhyIoUSBController".
yetus: proto/evecommon/devmodelcommon.proto#L27
buflint:Enum value name "PhyIoUSBController" should be prefixed with "PHY_IO_TYPE_".
yetus: proto/evecommon/devmodelcommon.proto#L27
buflint:Enum value name "PhyIoUSBController" should be UPPER_SNAKE_CASE, such as "PHY_IO_USB_CONTROLLER".
yetus: proto/evecommon/devmodelcommon.proto#L28
bufcompat:Enum value "14" on enum "PhyIoType" changed name from "PhyIoVCAN" to "PhyIoUSBDevice".
yetus: proto/evecommon/devmodelcommon.proto#L28
buflint:Enum value name "PhyIoUSBDevice" should be prefixed with "PHY_IO_TYPE_".
yetus: proto/evecommon/devmodelcommon.proto#L28
buflint:Enum value name "PhyIoUSBDevice" should be UPPER_SNAKE_CASE, such as "PHY_IO_USB_DEVICE".
yetus: proto/evecommon/devmodelcommon.proto#L29
bufcompat:Enum value "15" on enum "PhyIoType" changed name from "PhyIoLCAN" to "PhyIoCAN".

It complains about changing the IDs, which is expected and it complains about UPPER_SNAKE_CASE, but we want to keep the style.

Yeah, both can be ignored.

eriknordmark
eriknordmark approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 6180247 into lf-edge:main Feb 29, 2024
3 of 4 checks passed
@christoph-zededa christoph-zededa mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknordmark eriknordmark eriknordmark approved these changes

@rene rene rene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christoph-zededa @rene @eriknordmark