vm : add vmResolution field to VmConfig #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proto/config/vm.proto
Outdated
| @@ -80,4 +80,6 @@ message VmConfig { | |||
| bool enable_vnc_shim_vm = 22; | |||
| // Boot mode: Legacy or UEFI | |||
| VmBootMode boot_mode = 23; | |||
| // Custom resolution applies to VM that is runing in FML mode only. | |||
| string vmResolution = 24; | |||
| } | |||
There was a problem hiding this comment.
As far as I remember, the config that comes in vm.proto becomes a part of FixedResources. As far as I remember, it means we cannot change this part of config after the App has started without purging the app. I think the resolution should be more dynamic. In this case it should become a part of appconfig.proto
There was a problem hiding this comment.
good point, I'll update the PR.
The vm_resolution field is used to set the custom resolution for the VM running in FML mode. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vm_resolution field is used to set the custom resolution for the VM running in FML mode. This is to move FmlCustomResolution from cloud-init to AppInstanceConfig.