-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests to the repo #7
base: main
Are you sure you want to change the base?
Conversation
@liamwh would you be able to review this PR? The only test that doesn't seem to work out of the box is this one:
The issue is with the In my parser, I've defined an identifier like this: identifier: $ => /%?[a-zA-Z][a-zA-Z0-9-]*/, Whereas your identifier is more sophisticated and enforces kebab-case where each "word" can't start with a digit: Line 59 in 3d6124c
I checked
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks for your contribution!
Great PR @Michael-F-Bryan! Thanks for this contribution! 👍 Please re-generate the Regarding the ID regex: I don't see the issue with the id matching showing up in tests, so unless I'm mistaken, it appears we don't need to do anything with that regex at this time? Cheers, |
@Michael-F-Bryan Are you still willing to merge your changes to this repo? |
62fc4a7
to
57e31a6
Compare
This is a follow-up from the conversation in tree-sitter/tree-sitter#3348.