Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use docker/metadata-action #4421

Merged
merged 5 commits into from
Sep 12, 2023
Merged

ci: use docker/metadata-action #4421

merged 5 commits into from
Sep 12, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Sep 1, 2023

Description

Current approach is not robust to more complex branch names.

Related #4311 (comment).

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Current approach is not robust to more complex branch names.

See context in #4311 (comment)
@thomaseizinger thomaseizinger changed the title fix(.github/docker-image): use docker/metadata-action ci: use docker/metadata-action Sep 3, 2023
@thomaseizinger
Copy link
Contributor

I've changed this to run on master and pull_request instead so we get a tag for the merge commit of a PR, see https://github.com/libp2p/rust-libp2p/pkgs/container/rust-libp2p-server/126912021?tag=pr-4421 for example.

@mergify mergify bot merged commit b8f47aa into master Sep 12, 2023
68 of 69 checks passed
@mergify mergify bot deleted the github-docker-tag branch September 12, 2023 05:54
@thomaseizinger
Copy link
Contributor

Weirdly, what seems to have worked in this PR does not work in other PRs: https://github.com/libp2p/rust-libp2p/actions/runs/6156861489/job/16706395686?pr=4275

@mxinden
Copy link
Member Author

mxinden commented Sep 20, 2023

@thomaseizinger I am assuming that the failure is due to the fact that it comes from a fork and thus does not have the credentials.

@thomaseizinger
Copy link
Contributor

@thomaseizinger I am assuming that the failure is due to the fact that it comes from a fork and thus does not have the credentials.

Yep, I've fixed that since :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants