-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use docker/metadata-action
#4421
Conversation
Current approach is not robust to more complex branch names. See context in #4311 (comment)
docker/metadata-action
I've changed this to run on |
Weirdly, what seems to have worked in this PR does not work in other PRs: https://github.com/libp2p/rust-libp2p/actions/runs/6156861489/job/16706395686?pr=4275 |
@thomaseizinger I am assuming that the failure is due to the fact that it comes from a fork and thus does not have the credentials. |
Yep, I've fixed that since :) |
Description
Current approach is not robust to more complex branch names.
Related #4311 (comment).
Notes & open questions
Change checklist