Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rust-libp2p-server to monorepo #4311

Merged
merged 35 commits into from
Aug 21, 2023
Merged

feat: add rust-libp2p-server to monorepo #4311

merged 35 commits into from
Aug 21, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Aug 10, 2023

Description

Moves https://github.com/mxinden/rust-libp2p-server to the rust-libp2p monorepository.

Rust libp2p Server

A rust-libp2p based server implementation running:

Notes & open questions

Fixes mxinden/rust-libp2p-server#253.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

mxinden added 4 commits August 10, 2023 11:50
@mxinden
feat: add rust-libp2p-server to monorepo
f6d3e89 
Moves https://github.com/mxinden/rust-libp2p-server to the rust-libp2p monorepository.

> # Rust libp2p Server
>
> A rust-libp2p based server implementation running:
>
> - the [Kademlia protocol](https://github.com/libp2p/specs/tree/master/kad-dht)
>
> - the [Circuit Relay v2 protocol](https://github.com/libp2p/specs/blob/master/relay/circuit-v2.md)
>
> - the [AutoNAT protocol](https://github.com/libp2p/specs/blob/master/autonat/README.md)
@mxinden
Set versions
4693d04
@mxinden
Set rust-version
cae6986
@mxinden
fix: use pub(crate)
b8c955b
@mxinden mxinden mentioned this pull request Aug 10, 2023
Merged
4 tasks
@mxinden mxinden marked this pull request as ready for review August 10, 2023 12:05
@mxinden mxinden mentioned this pull request Aug 10, 2023
Merged
mxinden
mxinden commented Aug 14, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@mxinden
Copy link
Member Author

mxinden commented Aug 14, 2023

@thomaseizinger this is ready for a first review when you have time.

@mxinden mxinden requested a review from thomaseizinger August 14, 2023 13:50
thomaseizinger
thomaseizinger reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this!

misc/server/Cargo.toml Outdated Show resolved Hide resolved
misc/server/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
misc/server/src/http_service.rs Outdated Show resolved Hide resolved
misc/server/src/behaviour.rs Show resolved Hide resolved
@mxinden mxinden requested a review from thomaseizinger August 16, 2023 17:18
@mxinden mxinden mentioned this pull request Aug 18, 2023
Merged
4 tasks
@mxinden
Copy link
Member Author

mxinden commented Aug 18, 2023

@thomaseizinger anything else missing here from your end? I would like to merge in order to not maintain both https://github.com/mxinden/rust-libp2p-server/ and this pull request and to be able to continuously deploy again to our staging server.

thomaseizinger
thomaseizinger approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, nothing blocking :)

.github/workflows/docker-image.yml Outdated Show resolved Hide resolved
.github/workflows/docker-image.yml Outdated Show resolved Hide resolved
.github/workflows/docker-image.yml Outdated Show resolved Hide resolved
.github/workflows/docker-image.yml Show resolved Hide resolved
misc/server/Cargo.toml Outdated Show resolved Hide resolved
misc/server/Dockerfile Outdated Show resolved Hide resolved
misc/server/src/main.rs Show resolved Hide resolved
misc/server/src/main.rs Outdated Show resolved Hide resolved
misc/server/src/main.rs Outdated Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor

Haha dang, I think you'll have to add an exception that this crate is allowed to depend on libp2p.

mxinden and others added 6 commits August 21, 2023 19:12
@mxinden mxinden mentioned this pull request Aug 21, 2023
Open
@mergify mergify bot merged commit e974efb into master Aug 21, 2023
@mergify mergify bot deleted the server branch August 21, 2023 18:49
@mxinden mxinden mentioned this pull request Aug 24, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this pull request Aug 24, 2023
@mxinden
chore: prepare libp2p v0.52.3
e8759c8 
- Addresses TLS CVE:
- #4381
- #4378
- Stable QUIC #4325
- New rust-libp2p-server release #4311

Pull-Request: #4387.
mxinden added a commit that referenced this pull request Sep 1, 2023
@mxinden
fix(.github/docker-image): use docker/metadata-action
4628e7e 
Current approach is not robust to more complex branch names.

See context in #4311 (comment)
@mxinden mxinden mentioned this pull request Sep 1, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this pull request Sep 12, 2023
@mxinden
ci: use docker/metadata-action
b8f47aa 
Current approach is not robust to more complex branch names.

Related #4311 (comment).

Pull-Request: #4421.
@mxinden mxinden mentioned this pull request Nov 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Future of this repository
2 participants
@mxinden @thomaseizinger