Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL2] Fix order of events in case audio buffer size changes #11496

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

StephenCWills
Copy link
Contributor

Assign the length of audio buffer after obtaining the audio buffer.

Description

See #11122 (comment)

Existing Issue(s)

This resolves #11122

@sezero sezero requested a review from icculus November 18, 2024 20:47
@sezero
Copy link
Contributor

sezero commented Nov 23, 2024

@icculus: This looks correct -- can you review?

@sezero
Copy link
Contributor

sezero commented Nov 28, 2024

I'm going ahead and merging this.

@sezero sezero merged commit a4ec0b1 into libsdl-org:SDL2 Nov 28, 2024
40 checks passed
@StephenCWills StephenCWills deleted the audio-buf-size-change-ooe branch November 28, 2024 21:25
@icculus
Copy link
Collaborator

icculus commented Nov 28, 2024

Oh, this was a good fix, sorry I didn't reply to this sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants