Purify AppState #273
Merged
Purify AppState #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove clearIfFull function, move that logic to Executor - Remove logger from AppState, move that logic to Executor
lenguyenthanh
force-pushed
the
purify-app-state
branch
from
69ca0ea
to
f5a585d
Compare
Faster and better
lenguyenthanh
force-pushed
the
purify-app-state
branch
from
f5a585d
to
47df4d5
Compare
lenguyenthanh
force-pushed
the
purify-app-state
branch
from
39c27a8
to
48150fc
Compare
Avoid confusion between ClientKey vs apikey
lenguyenthanh
force-pushed
the
purify-app-state
branch
from
48150fc
to
58714db
Compare
ornicar
requested changes
Feb 27, 2024
lenguyenthanh
force-pushed
the
purify-app-state
branch
from
a5e184f
to
d3b7d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all effects from AppState