-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xilem: Add message_handler view #456
Conversation
Yeah that's not optimal, FWIW it's similar to what I did in #452. Other than that it looks good so far to me. |
Aah, that clarifies things! Thanks a lot for the explanation! |
This is another thing which interacts with hot reloading; in that case, we would definitely need to move things around. I have a design in my, but it is yet to be tested/implemented. |
I don't think a |
Btw, let's close this and #463 to clean up the list of PRs? I suppose there's no any value in them, besides just exploring how such views could be implemented |
I'll close it for now to keep the PR list clean, but will keep the branch around for a while just in case. |
This PR implements @Philipp-M idea for a
channel
view from this message. For now I took liberty to rename it tomessage_handler
, as it seems like the main purpose of the view, while the rest is just a machinery for extractingMessageProxy
to it, but it can be changed of course.I've implemented it just for practice and to aid the discussion, I'm not actually proposing to merge it (at least yet, UPD: I now think #463 is a more ergonomic option). Especially I'm not sure if my hack with deferring
store_proxy
toView::message
call (just for giving it access to mutable app data) is a good pattern.