[#8467] Display questions (Filters and Like buttons) #5744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevfurneaux
commented
Nov 13, 2024
sevfurneaux
force-pushed
the
sf-2024-10-display-questions
branch
from
353354d
to
671c9e2
Compare
sevfurneaux
changed the title
vellip
requested changes
Nov 13, 2024
sevfurneaux
force-pushed
the
sf-2024-10-display-questions
branch
2 times, most recently
from
dcfb26b
to
68f2f1c
Compare
|
Thanks for your comments @vellip! Hopefully I've got all of them, alongside converting to functional components. |
vellip
approved these changes
Nov 13, 2024
Comment on lines
9
to
11
| useEffect(() => { | ||
| setIsOnShortlist(isOnShortlist) | ||
| }, [isOnShortlist]) |
There was a problem hiding this comment.
It's for users that are on "shortlists": I've reverted the HTML for this, in case there will be a future ticket to style it: https://github.com/liqd/a4-meinberlin/pull/5744/files#diff-049654a90fe27d059ce8bf97f8bfba60e7543bc13b2e847888e1010604fb2462R43-R47
sevfurneaux
force-pushed
the
sf-2024-10-display-questions
branch
from
68f2f1c
to
adcd33e
Compare
@vellip thanks for your comments as well! Merged 🚀 |
sevfurneaux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR:
<Filters />component and changes the filters to be submittable via a<button /><LikeCard />component used in both<QuestionModerator />and<QuestionUser /><Filters /><LikeCard />Tasks