Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8467] Display questions (Filters and Like buttons) #5744

Merged
merged 1 commit into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/_8467.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
### Changed

- Restyled `Filters` component and added filter button

### Added

- Added new `LikeCard` component
– Added `LikeCard` component to `QuestionModerator` and `QuestionUser` components
81 changes: 0 additions & 81 deletions meinberlin/assets/scss/components/_live_questions.scss
Original file line number Diff line number Diff line change
@@ -1,68 +1,3 @@
.live_questions__filters {
@media screen and (min-width: $breakpoint-xs) {
display: inline-flex;
}
}

.live_questions__filters--parent {
width: 100%;
justify-content: space-between;
margin-bottom: $spacer;

@media screen and (min-width: $breakpoint-xs) {
display: inline-flex;
}
}

.live_questions__filters--dropdown {
@media screen and (min-width: $breakpoint-xs) {
margin-right: $spacer;
margin-bottom: 0;
}

button {
min-width: 100%;
}
}

.live_questions__filters--btns {
width: 100%;
display: inline-flex;
justify-content: flex-end;

.switch--btn {
border-radius: $border-radius;
}
}

.live_questions__filters--screen-btn {
width: 100%;
}

.live-question__action-bar {
width: 100%;
display: inline-flex;
justify-content: space-between;
}

.live_questions__question {
font-size: $font-size-lg;
margin-bottom: 0.25 * $spacer;
}

.infobox__box {
background-color: $bg-tertiary;
padding: 0.5 * $spacer $spacer;
font-size: $font-size-sm;
margin-bottom: $spacer;

i {
position: absolute;
color: $primary;
line-height: 1.2rem;
}
}

.infobox__text {
margin-left: 2 * $spacer;
}
Expand Down Expand Up @@ -122,10 +57,6 @@
z-index: 1;
}

.checkbox-btn {
display: inline-block;
}

.live_questions_infographic__footer {
position: fixed;
right: 0;
Expand Down Expand Up @@ -177,10 +108,6 @@
}
}

.live_questions__like {
padding-top: 0.5 * $spacer;
}

.live_question__presentation {
margin-top: 5 * $spacer;
}
Expand All @@ -196,11 +123,3 @@
font-size: 0.6rem;
line-height: inherit;
}

.live_questions__select > .select2-container {
min-width: 100%;

@media screen and (min-width: $breakpoint-xs) {
min-width: 15rem;
}
}
4 changes: 4 additions & 0 deletions meinberlin/assets/scss/components_user_facing/_card.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,7 @@
.card__link--hover {
text-decoration: underline !important; // BO overide
}

.card__pill {
margin-bottom: 0.3em;
}
8 changes: 4 additions & 4 deletions meinberlin/assets/scss/components_user_facing/_rating.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
i {
margin-right: 0.4em;
margin-bottom: 0.4em;
display: block;
display: inline;
}

@media screen and (min-width: $breakpoint-palm) {
display: inline;
}
&--active {
font-weight: bold;
}

.fa-chevron-up:before {
Expand Down
207 changes: 114 additions & 93 deletions meinberlin/react/livequestions/Filters.jsx
Original file line number Diff line number Diff line change
@@ -1,103 +1,124 @@
import React from 'react'
import React, { useState } from 'react'
import django from 'django'

export default class Filter extends React.Component {
selectCategory (e) {
const allTag = django.gettext('all')
const onlyShowMarkedText = django.gettext('only show marked questions')
const displayNotHiddenText = django.gettext('display only questions which are not hidden')
const orderLikesText = django.gettext('order by likes')
const questionsText = django.gettext('Questions')
const filterText = django.gettext('Filter')
const affiliationText = django.gettext('Affiliation')

const Filter = ({
categories,
isModerator,
displayOnShortlist,
toggleDisplayOnShortlist,
displayNotHiddenOnly,
toggledisplayNotHiddenOnly,
orderedByLikes,
toggleOrdering,
setCategories
}) => {
const [category, setCategory] = useState(null)

const selectCategory = (e) => {
e.preventDefault()
const category = e.target.getAttribute('data-value')
this.props.setCategories(category)
setCategory(e.target.value)
}

getButtonClass () {
if (this.props.currentCategory === '-1') {
return 'btn btn--light btn--select live_questions__filters--dropdown dropdown-toggle'
} else {
return 'btn btn--light btn--select live_questions__filters--dropdown dropdown-toggle'
const handleSubmit = (e) => {
e.preventDefault()
if (category) {
setCategories(category)
}
}

render () {
const allTag = django.gettext('all')
const onlyShowMarkedText = django.gettext('only show marked questions')
const displayNotHiddenText = django.gettext('display only questions which are not hidden')
const orderLikesText = django.gettext('order by likes')
return (
<div className="live_questions__filters">
{this.props.categories.length > 0
? <div className="dropdown live_questions__filters--dropdown">
<button
className={this.getButtonClass()} type="button" id="dropdownMenuButton"
data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false"
return (
<>
<h2 id="filter-form-heading">{questionsText}</h2>
<form className="form panel--heavy" onSubmit={handleSubmit} aria-labelledby="filter-form-heading">
{categories.length > 0 && (
<div className="form-group">
<label htmlFor="filterCategorySelect">{affiliationText}*</label>
<select
id="filterCategorySelect"
className="form-control"
onChange={selectCategory}
>
{this.props.currentCategoryName}
<i className="fa fa-caret-down" aria-label={onlyShowMarkedText} />
</button>
<div className="dropdown-menu" aria-labelledby="dropdownMenuButton">
<button className="dropdown-item" data-value={-1} onClick={this.selectCategory.bind(this)} href="#">{allTag}</button>
{this.props.categories.map((category, index) => {
return <button className="dropdown-item" key={index} data-value={category} onClick={this.selectCategory.bind(this)} href="#">{category}</button>
})}
</div>
</div> // eslint-disable-line react/jsx-closing-tag-location
: ''}
{this.props.isModerator &&
<div className="live_questions__filters--btns">
<div className="checkbox-btn u-spacer-right">
<label
htmlFor="markedCheck"
className={'btn switch--btn' + (this.props.displayOnShortlist ? ' active' : '')}
title={onlyShowMarkedText}
>
<input
className="radio__input"
type="checkbox"
id="markedCheck"
name="markedCheck"
checked={this.props.displayOnShortlist}
onChange={this.props.toggleDisplayOnShortlist} // eslint-disable-line react/jsx-handler-names
/>
<span className="visually-hidden">{onlyShowMarkedText}</span>
<i className="far fa-list-alt" aria-hidden="true" />
</label>
</div>
<div className="checkbox-btn u-spacer-right">
<label
htmlFor="displayNotHiddenOnly"
className={'btn switch--btn' + (this.props.displayNotHiddenOnly ? ' active' : '')}
title={displayNotHiddenText}
>
<input
className="radio__input"
type="checkbox"
id="displayNotHiddenOnly"
name="displayNotHiddenOnly"
checked={this.props.displayNotHiddenOnly}
onChange={this.props.toggledisplayNotHiddenOnly} // eslint-disable-line react/jsx-handler-names
/>
<span className="visually-hidden">{displayNotHiddenText}</span>
<i className="far fa-eye" aria-hidden="true" />
</label>
</div>
<div className="checkbox-btn">
<label
htmlFor="orderedByLikes"
className={'btn switch--btn' + (this.props.orderedByLikes ? ' active' : '')}
title={orderLikesText}
>
<input
className="radio__input"
type="checkbox"
id="orderedByLikes"
name="orderedByLikes"
checked={this.props.orderedByLikes}
onChange={this.props.toggleOrdering} // eslint-disable-line react/jsx-handler-names
/>
<span className="visually-hidden">{orderLikesText}</span>
<i className="far fa-thumbs-up" aria-hidden="true" />
</label>
</div>
</div>}
</div>
)
}
<option value={-1}>{allTag}</option>
{categories.map((cat) => (
<option key={cat} value={cat}>{cat}</option>
))}
</select>
</div>
)}
<div className="form-actions">
<div className="form-actions__right">
<button type="submit" className="button">{filterText}</button>
</div>
</div>
</form>
{isModerator && (
<div className="block">
<div className="checkbox-btn u-spacer-right">
<label
htmlFor="markedCheck"
className={'btn switch--btn' + (displayOnShortlist ? ' active' : '')}
title={onlyShowMarkedText}
>
<input
className="radio__input"
type="checkbox"
id="markedCheck"
name="markedCheck"
checked={displayOnShortlist}
onChange={toggleDisplayOnShortlist}
/>
<span className="visually-hidden">{onlyShowMarkedText}</span>
<i className="far fa-list-alt" aria-hidden="true" />
</label>
</div>
<div className="checkbox-btn u-spacer-right">
<label
htmlFor="displayNotHiddenOnly"
className={'btn switch--btn' + (displayNotHiddenOnly ? ' active' : '')}
title={displayNotHiddenText}
>
<input
className="radio__input"
type="checkbox"
id="displayNotHiddenOnly"
name="displayNotHiddenOnly"
checked={displayNotHiddenOnly}
onChange={toggledisplayNotHiddenOnly}
/>
<span className="visually-hidden">{displayNotHiddenText}</span>
<i className="far fa-eye" aria-hidden="true" />
</label>
</div>
<div className="checkbox-btn">
<label
htmlFor="orderedByLikes"
className={'btn switch--btn' + (orderedByLikes ? ' active' : '')}
title={orderLikesText}
>
<input
className="radio__input"
type="checkbox"
id="orderedByLikes"
name="orderedByLikes"
checked={orderedByLikes}
onChange={toggleOrdering}
/>
<span className="visually-hidden">{orderLikesText}</span>
<i className="far fa-thumbs-up" aria-hidden="true" />
</label>
</div>
</div>
)}
</>
)
}

export default Filter
Loading
Loading