-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8683] platform-mail: update styling #5919
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, I left a question regarding the bootstrap classes. The story says the button to get to the email form should be in the burger menu, however currently it's in the user indicator, right? I forgot what we discussed yesterday, did we say to not move it for now?
Edit: ah nevermind, just saw your burger menu PR!
</div> | ||
</form> | ||
<div class="narrow-wrapper"> | ||
<div class="offset-lg-3 col-lg-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not up to scratch about the redesign process, but aren't those bootstrap classes? Is it ok to use them outside of the dashboard (or does this still count as dashboard?) ?
<div class="narrow-wrapper"> | ||
<div class="offset-lg-3 col-lg-6"> | ||
<h1>{% translate 'Create platform email' %}</h1> | ||
<p class="form-hint"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the margin between the heading and the form-hint seems a bit too big compared to the design, but also I'm not sure if that matters ?
Describe your changes
adapt page to new styling and make sender field required and adapt default values for form.
Tasks