Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8683] platform-mail: update styling #5919

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Jan 8, 2025

Describe your changes
adapt page to new styling and make sender field required and adapt default values for form.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@vellip vellip requested review from goapunk and hom3mad3 January 8, 2025 14:09
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, I left a question regarding the bootstrap classes. The story says the button to get to the email form should be in the burger menu, however currently it's in the user indicator, right? I forgot what we discussed yesterday, did we say to not move it for now?

Edit: ah nevermind, just saw your burger menu PR!

</div>
</form>
<div class="narrow-wrapper">
<div class="offset-lg-3 col-lg-6">
Copy link
Contributor

@goapunk goapunk Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not up to scratch about the redesign process, but aren't those bootstrap classes? Is it ok to use them outside of the dashboard (or does this still count as dashboard?) ?

<div class="narrow-wrapper">
<div class="offset-lg-3 col-lg-6">
<h1>{% translate 'Create platform email' %}</h1>
<p class="form-hint">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the margin between the heading and the form-hint seems a bit too big compared to the design, but also I'm not sure if that matters ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants