-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8683] platform-mail: update styling #5919
Open
vellip
wants to merge
1
commit into
dev
Choose a base branch
from
pv-2025-01-platform-mail-design
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
### Changed | ||
- New design for platform mail form | ||
- sender field is now required to prevent issues with email clients | ||
- CKEditor styling for redesign | ||
- change default values for fields in platform email form | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 26 additions & 29 deletions
55
meinberlin/apps/platformemails/templates/meinberlin_platformemails/platformemail_form.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,33 @@ | ||
{% extends "a4dashboard/base_dashboard.html" %} | ||
{% extends "base.html" %} | ||
{% load i18n userindicator %} | ||
{% block title %} | ||
{% translate 'Create platform email' %} | ||
{% translate 'Create platform email' %} | ||
{% endblock title %} | ||
{% block content %} | ||
<div class="container"> | ||
{% userindicator %} | ||
<div class="offset-lg-3 col-lg-6"> | ||
<h1>{% translate 'Create platform email' %}</h1> | ||
<p class="form-hint"> | ||
{% blocktranslate %}This email will be sent to all registered and verified users of mein.berlin.de.{% endblocktranslate %} | ||
</p> | ||
<form novalidate | ||
enctype="multipart/form-data" | ||
action="{{ request.path }}" | ||
method="post"> | ||
{% csrf_token %} | ||
{{ form.media }} | ||
<div class="l-tiles-2"> | ||
{% include 'a4forms/includes/form_field.html' with field=form.sender_name %} | ||
{% include 'a4forms/includes/form_field.html' with field=form.sender %} | ||
</div> | ||
{% include 'a4forms/includes/form_field.html' with field=form.subject %} | ||
{% include 'a4forms/includes/form_field.html' with field=form.body %} | ||
<div class="u-spacer-bottom"> | ||
<input type="submit" | ||
class="btn btn--primary" | ||
name="send" | ||
value="{% translate 'Send' %}" /> | ||
<a href="{% url 'wagtail_serve' '' %}" class="btn btn--light">{% translate 'Cancel' %}</a> | ||
</div> | ||
</form> | ||
<div class="narrow-wrapper"> | ||
<div class="offset-lg-3 col-lg-6"> | ||
<h1>{% translate 'Create platform email' %}</h1> | ||
<p class="form-hint"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the margin between the heading and the form-hint seems a bit too big compared to the design, but also I'm not sure if that matters ? |
||
{% blocktranslate %}This email will be sent to all registered and verified users of mein.berlin.de.{% endblocktranslate %} | ||
</p> | ||
<form novalidate | ||
enctype="multipart/form-data" | ||
action="{{ request.path }}" | ||
method="post"> | ||
{% csrf_token %} | ||
{{ form.media }} | ||
<div class="l-tiles-2"> | ||
{% include 'meinberlin_contrib/includes/form_field.html' with field=form.sender_name %} | ||
{% include 'meinberlin_contrib/includes/form_field.html' with field=form.sender %} | ||
</div> | ||
{% include 'meinberlin_contrib/includes/form_field.html' with field=form.subject %} | ||
{% include 'meinberlin_contrib/includes/form_field.html' with field=form.body %} | ||
|
||
<div class="narrow-wrapper__secondary-cta narrow-wrapper__secondary-cta--left"> | ||
<a href="{% url 'wagtail_serve' '' %}">{% translate 'Cancel' %}</a> | ||
</div> | ||
<button type="submit" class="button button--full-width" name="send">{% translate 'Send' %}</button> | ||
</form> | ||
</div> | ||
</div> | ||
{% endblock content %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
meinberlin/assets/scss/components_user_facing/ck-editor/_base.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
.ck .ck-toolbar { | ||
border: 2px solid black !important; | ||
border-bottom: none !important; | ||
} | ||
|
||
.ck .ck-editor__editable { | ||
border: 2px solid black !important; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not up to scratch about the redesign process, but aren't those bootstrap classes? Is it ok to use them outside of the dashboard (or does this still count as dashboard?) ?