Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App env consistency #117

Merged
merged 1 commit into from
Apr 15, 2024
Merged

App env consistency #117

merged 1 commit into from
Apr 15, 2024

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Apr 15, 2024

  • Ensure the Liquity testnet explorer is named the same everywhere.
  • CHAIN_RPC_URL now checks for a URL rather than a string only.
  • Invalid values are not ignored anymore for the following:
    • CHAIN_BLOCK_EXPLORER
    • CHAIN_CONTRACT_ENS_REGISTRY
    • CHAIN_CONTRACT_ENS_RESOLVER
    • CHAIN_CONTRACT_MULTICALL

@bpierre
App env consistency
2d1f98b 
- Ensure the Liquity testnet explorer is named the same everywhere.
- CHAIN_RPC_URL now checks for a URL rather than a string only.
- Invalid values are not ignored anymore for the following:
  -  CHAIN_BLOCK_EXPLORER
  -  CHAIN_CONTRACT_ENS_REGISTRY
  -  CHAIN_CONTRACT_ENS_RESOLVER
  -  CHAIN_CONTRACT_MULTICALL
@bpierre bpierre mentioned this pull request Apr 15, 2024
Merged
danielattilasimon
danielattilasimon approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@danielattilasimon danielattilasimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice fix 👍 👍 , I actually ran into an issue where an invalid env value was being ignored, which resulted in the block explorer not being added to MetaMask upon connection.

@bpierre
Copy link
Contributor Author

bpierre commented Apr 15, 2024

This is a nice fix 👍 👍 , I actually ran into an issue where an invalid env value was being ignored, which resulted in the block explorer not being added to MetaMask upon connection.

Yes, that’s exactly the issue I ran into! 😄

@bpierre bpierre merged commit 7bf8503 into main Apr 15, 2024
2 checks passed
@bpierre bpierre deleted the app-env-consistency branch April 19, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielattilasimon danielattilasimon danielattilasimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpierre @danielattilasimon