Skip to content

Commit

Permalink
Merge branch 'master' into 201-add-sendchatmessage-api-endpoint
Browse files Browse the repository at this point in the history
  • Loading branch information
SamuelWei committed Sep 14, 2024
2 parents c2bccf2 + 13fabd0 commit 7dc4e5f
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 5 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"psr/http-factory": "^1.0",
"psr/http-message": "^1.0 || ^2.0",
"symfony/dotenv": "^5.4|^6.4|^7.0",
"symfony/http-client-contracts": "^1.1|^2.0",
"symfony/http-client-contracts": "^1.1|^2.0|^3.0",
"symfony/http-client": "^5.4|^6.4|^7.0",
"symfony/process": "^5.4|^6.4|^7.0",
"nyholm/psr7": "^1.4"
Expand Down
7 changes: 7 additions & 0 deletions src/Core/Record.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class Record
{
private readonly string $recordId;
private readonly string $meetingId;
private readonly string $internalMeetingId;
private readonly string $name;
private readonly bool $isPublished;
private readonly string $state;
Expand All @@ -45,6 +46,7 @@ public function __construct(\SimpleXMLElement $xml)
{
$this->recordId = $xml->recordID->__toString();
$this->meetingId = $xml->meetingID->__toString();
$this->internalMeetingId = $xml->internalMeetingID->__toString();
$this->name = $xml->name->__toString();
$this->isPublished = $xml->published->__toString() === 'true';
$this->state = $xml->state->__toString();
Expand All @@ -71,6 +73,11 @@ public function getMeetingId(): string
return $this->meetingId;
}

public function getInternalMeetingId(): string
{
return $this->internalMeetingId;
}

public function getName(): string
{
return $this->name;
Expand Down
4 changes: 2 additions & 2 deletions src/Parameters/CreateMeetingParameters.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
* @method $this setWelcome(string $welcome)
* @method string getDialNumber()
* @method $this setDialNumber(string $dialNumber)
* @method string getVoiceBridge()
* @method $this setVoiceBridge(string $voiceBridge)
* @method int getVoiceBridge()
* @method $this setVoiceBridge(int $voiceBridge)
* @method string getWebVoice()
* @method $this setWebVoice(string $webVoice)
* @method int getMaxParticipants()
Expand Down
2 changes: 1 addition & 1 deletion src/Util/UrlBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ final class UrlBuilder
public function __construct(
private readonly string $securitySalt,
private readonly string $bbbServerBaseUrl,
private readonly HashingAlgorithm $hashingAlgorithm
private readonly HashingAlgorithm $hashingAlgorithm,
) {
}

Expand Down
4 changes: 3 additions & 1 deletion tests/unit/BigBlueButtonTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ public function testGetMeetings(): void
$this->assertEquals('12345', $response->getMeetings()[0]->getInternalMeetingId());
$this->assertEquals(1531241258036, $response->getMeetings()[0]->getCreationTime());
$this->assertEquals('Tue Jul 10 16:47:38 UTC 2018', $response->getMeetings()[0]->getCreationDate());
$this->assertEquals('70066', $response->getMeetings()[0]->getVoiceBridge());
$this->assertEquals(70066, $response->getMeetings()[0]->getVoiceBridge());
$this->assertEquals('613-555-1234', $response->getMeetings()[0]->getDialNumber());
$this->assertFalse($response->getMeetings()[0]->isRunning());
$this->assertEquals(0, $response->getMeetings()[0]->getDuration());
Expand All @@ -380,6 +380,7 @@ public function testGetRecordings(): void
<recording>
<recordID>f71d810b6e90a4a34ae02b8c7143e8733178578e-1462807897120</recordID>
<meetingID>9d287cf50490ca856ca5273bd303a7e321df6051-4-119</meetingID>
<internalMeetingID>c654308ef4b71eeb74eb8436dc52a31415d9a911-1724671588959</internalMeetingID>
<name><![CDATA[SAT- Writing-Humanities (All participants)]]></name>
<published>true</published>
<state>published</state>
Expand Down Expand Up @@ -415,6 +416,7 @@ public function testGetRecordings(): void
$recording = $response->getRecords()[0];
$this->assertEquals('f71d810b6e90a4a34ae02b8c7143e8733178578e-1462807897120', $recording->getRecordID());
$this->assertEquals('9d287cf50490ca856ca5273bd303a7e321df6051-4-119', $recording->getMeetingID());
$this->assertEquals('c654308ef4b71eeb74eb8436dc52a31415d9a911-1724671588959', $recording->getInternalMeetingID());
$this->assertEquals('SAT- Writing-Humanities (All participants)', $recording->getName());
}

Expand Down

0 comments on commit 7dc4e5f

Please sign in to comment.