Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- changed the type from string to integer for the setter und getter o… #211

Merged

Conversation

marineusde
Copy link

…f the voiceBridge

@marineusde
Copy link
Author

If I run "composer cs-test" or "tools/php-cs-fixer fix --dry-run" in my console (debian linux), there are no errors. Anyone got an idea why the pipeline failed?

@FelixJacobi
Copy link
Member

If I run "composer cs-test" or "tools/php-cs-fixer fix --dry-run" in my console (debian linux), there are no errors. Anyone got an idea why the pipeline failed?

Have you ensured, that the tool is up-to-date? You can run composer update in tools/.php-cs-fixer to do so.

@marineusde
Copy link
Author

If I run "composer cs-test" or "tools/php-cs-fixer fix --dry-run" in my console (debian linux), there are no errors. Anyone got an idea why the pipeline failed?

Have you ensured, that the tool is up-to-date? You can run composer update in tools/.php-cs-fixer to do so.

yes, not it works. The interesting thing is, that the cs fixer in the pipeline (https://github.com/littleredbutton/bigbluebutton-api-php/actions/runs/10791709737/job/29929705516?pr=211) marked the file src/Util/UrlBuilder.php. I didnt changed anything in the file.

I fixed the style of the file in a second commit now.

@FelixJacobi FelixJacobi merged commit 13fabd0 into littleredbutton:master Sep 13, 2024
6 checks passed
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (7f7320f) to head (4a8f5fd).
Report is 21 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
- Coverage     98.85%   98.73%   -0.12%     
+ Complexity      480      446      -34     
============================================
  Files            53       52       -1     
  Lines          1131     1027     -104     
============================================
- Hits           1118     1014     -104     
  Misses           13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants