Skip to content

Commit

Permalink
Merge branch 'main' into release-please--branches--main
Browse files Browse the repository at this point in the history
  • Loading branch information
drstrangelooker authored Oct 28, 2024
2 parents 4e0d0ca + bae0fe3 commit edebcd1
Show file tree
Hide file tree
Showing 11 changed files with 158 additions and 116 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/apix-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:
- packages/extension-api-explorer/**
- packages/extension-utils/**
- .github/workflows/apix-ci.yml
- yarn.lock

push:
branches:
Expand All @@ -21,6 +22,7 @@ on:
- packages/extension-api-explorer/**
- packages/extension-utils/**
- .github/workflows/apix-ci.yml
- yarn.lock

workflow_dispatch:

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/codegen-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
- packages/sdk-codegen-utils/**
- packages/sdk-codegen-scripts/**
- .github/workflows/codegen-ci.yml
- yarn.lock

push:
branches:
Expand All @@ -17,6 +18,7 @@ on:
- packages/sdk-codegen-utils/**
- packages/sdk-codegen-scripts/**
- .github/workflows/codegen-ci.yml
- yarn.lock

workflow_dispatch:

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/hackathon-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- packages/wholly-artifact/**
- packages/hackathon/**
- .github/workflows/hackathon-ci.yml
- yarn.lock

push:
branches:
Expand All @@ -15,6 +16,7 @@ on:
- packages/wholly-artifact/**
- packages/hackathon/**
- .github/workflows/hackathon-ci.yml
- yarn.lock

workflow_dispatch:

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/python-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,17 @@ on:
paths:
- python/**
- .github/workflows/python-ci.yml
- Pipfile
- Pipfile.lock

push:
branches:
- main
paths:
- python/**
- .github/workflows/python-ci.yml
- Pipfile
- Pipfile.lock

workflow_dispatch:

Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/required-checks-hack-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,23 @@ jobs:
- 'packages/extension-api-explorer/**/*'
- 'packages/extension-utils/**/*'
- '.github/workflows/apix-ci.yml'
- 'yarn.lock'
codegen:
- 'package.json'
- 'packages/sdk-codegen/**/*'
- 'packages/sdk-codegen-utils/**/*'
- 'packages/sdk-codegen-scripts/**/*'
- '.github/workflows/codegen-ci.yml'
- 'yarn.lock'
hackathon:
- 'package.json'
- 'packages/wholly-sheet/**/*'
- 'packages/hackathon/**/*'
- '.github/workflows/hackathon-ci.yml'
- 'yarn.lock'
python:
- 'Pipfile'
- 'Pipfile.lock'
- 'python/**/*'
- '.github/workflows/python-ci.yml'
resources:
Expand All @@ -78,6 +83,7 @@ jobs:
- 'packages/extension-sdk-react/**/*'
- 'packages/extension-utils/**/*'
- '.github/workflows/tssdk-ci.yml'
- 'yarn.lock'
gosdk:
- 'packages/go/**/*'
- '.github/workflows/go-ci.yml'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/tssdk-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
- packages/extension-sdk-react/**
- packages/extension-utils/**
- .github/workflows/tssdk-ci.yml
- yarn.lock

push:
branches:
Expand All @@ -23,6 +24,7 @@ on:
- packages/extension-sdk-react/**
- packages/extension-utils/**
- .github/workflows/tssdk-ci.yml
- yarn.lock

workflow_dispatch:

Expand Down
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
"@types/js-yaml": "^3.12.1",
"@types/lodash": "4.14.172",
"@types/node": "22.5.4",
"@types/prettier": "2.7.3",
"@types/uuid": "^8.3.4",
"@typescript-eslint/eslint-plugin": "^5.61.0",
"@typescript-eslint/parser": "^5.61.0",
Expand Down Expand Up @@ -144,7 +145,6 @@
"npm-run-all": "4.1.5",
"openapi3-ts": "2.0.2",
"pre-commit": "1.2.2",
"@types/prettier": "2.7.3",
"prettier": "2.8.8",
"pretty-quick": "2.0.2",
"react": "^17.0.2",
Expand All @@ -160,8 +160,7 @@
"uuid": "9.0.1",
"webpack": "5.94.0",
"webpack-bundle-analyzer": "^4.10.2",
"webpack-merge": "^5.10.0",
"yarn-deduplicate": "6.0.2"
"webpack-merge": "^5.10.0"
},
"lint-staged": {
"**/*.ts?(x)": [
Expand Down Expand Up @@ -345,5 +344,7 @@
"**/url-parse": ">= 1.5.7",
"parse-url": "^8.1.0"
},
"dependencies": {}
"dependencies": {
"yarn-deduplicate": "^6.0.2"
}
}
1 change: 0 additions & 1 deletion packages/extension-sdk/src/connect/tile/tile_sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*/

import type { MouseEvent } from 'react';
import { NOT_DASHBOARD_MOUNT_NOT_SUPPORTED_ERROR } from '../../util/errors';
import { ExtensionRequestType } from '../types';
import type { ExtensionHostApiImpl } from '../extension_host_api';
Expand Down
1 change: 0 additions & 1 deletion packages/extension-sdk/src/connect/tile/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*/

import type { MouseEvent } from 'react';
import type { IQuery } from '@looker/sdk';

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*/
import React, { useCallback, useContext, useState } from 'react';
import type { MouseEvent } from 'react';
import {
Accordion2,
ButtonOutline,
Expand Down Expand Up @@ -58,17 +57,20 @@ export const EventTester: React.FC = () => {
}, [tileSDK]);

const toggleCrossFilterClick = useCallback(
(event: MouseEvent) => {
(event: React.MouseEvent<HTMLButtonElement>) => {
// TODO pivot and row data needs to be populated
tileSDK.toggleCrossFilter({ pivot: {} as any, row: {} as any }, event);
tileSDK.toggleCrossFilter(
{ pivot: {} as any, row: {} as any },
event as unknown as MouseEvent
);
},
[tileSDK]
);

const openDrillMenuClick = useCallback(
(event: MouseEvent) => {
(event: React.MouseEvent<HTMLButtonElement>) => {
// TODO links data needs to be populated
tileSDK.openDrillMenu({ links: [] }, event);
tileSDK.openDrillMenu({ links: [] }, event as unknown as MouseEvent);
},
[tileSDK]
);
Expand Down
Loading

0 comments on commit edebcd1

Please sign in to comment.