chore: Update sdk_gen script to lint and not do smoke tests #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drstrangelooker
previously approved these changes
Feb 21, 2024
Go Tests 6 files 6 suites 4m 40s ⏱️ Results for commit 85f946c. |
jeremytchang
force-pushed
the
update_script
branch
from
85f946c to
4791ef1
Compare
drstrangelooker
approved these changes
Feb 21, 2024
jkaster
reviewed
Feb 21, 2024
Comment on lines
+196
to
+198
| 'yarn fix', // Lint fix typescript | ||
| 'pipenv run black python/looker_sdk/sdk/api40/*.py', // Lint fix python | ||
| './kotlin/gradlew -p kotlin spotlessApply', // Lint fix kotlin |
There was a problem hiding this comment.
You gots to do what you gots to do. Would be nice for this to be a one liner to another script, but nice can come later.
| @@ -214,6 +216,7 @@ const regen = async (release) => { | |||
| const args = process.argv.slice(2); | |||
| if (args.length >= 1) { | |||
| await regen(args[0]); | |||
| console.info('If generated SDKs fail CI, run "bin/smoke [language]" locally to verify and debug') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn fixto the script. For some reason, our pre-commit hook hangs on eslint. So if we first fix the eslint issues withyarn fixthis lets our pre-commit hook work.Additionally:
Confirmed it generates sdk with consistent styling. From last generation:
26 files changed, 519 insertions(+), 188 deletions(-)