Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update sdk_gen script to lint and not do smoke tests #1431

Merged
merged 2 commits into from
Feb 21, 2024
Merged

chore: Update sdk_gen script to lint and not do smoke tests #1431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d733415
update script
jeremytchang Feb 21, 2024
4791ef1
update sdk gen script
jeremytchang Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bin/sdk_gen
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ const regen = async (release) => {
return batch(
[
'yarn gen',
'bin/smoke typescript python kotlin',
'yarn fix', // Lint fix typescript
'pipenv run black python/looker_sdk/sdk/api40/*.py', // Lint fix python
'./kotlin/gradlew -p kotlin spotlessApply', // Lint fix kotlin
Comment on lines +196 to +198
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You gots to do what you gots to do. Would be nice for this to be a one liner to another script, but nice can come later.

'git add -u',
`git commit -m "feat: generate SDKs for Looker ${release}" -m "Release-As: ${release}.0"`,
`git push origin ${branch}`,
Expand All @@ -214,6 +216,7 @@ const regen = async (release) => {
const args = process.argv.slice(2);
if (args.length >= 1) {
await regen(args[0]);
console.info('If generated SDKs fail CI, run "bin/smoke [language]" locally to verify and debug')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

} else {
console.error('No release version was specified');
}
Expand Down
Loading