fix: Remove the requests package from the TypeScript SDK #1491

jkaster · 2024-08-26T16:59:51Z

Removes the request package from all TypeScript SDK packages

Requires Node v22
For browser, uses the standard fetch function
For NodeJS, uses Node v22 global fetch function

Addresses #1439

Includes removal of the deprecated node Request package WIP, build is still broken on extension SDKs

Updated readmes also

jest.config.js

packages/sdk-node/src/nodeTransport.ts

github-actions · 2024-08-26T17:02:12Z

Typescript Tests

1 files - 9 28 suites - 36 24s ⏱️ - 5m 39s
208 tests - 19 207 ✅ - 16 1 💤 - 3 0 ❌ ±0
222 runs - 434 221 ✅ - 403 1 💤 - 31 0 ❌ ±0

Results for commit 08fc612. ± Comparison against base commit cb1e948.

This pull request removes 30 and adds 11 tests. Note that renamed tests count towards both.

LookerNodeSDK Dashboard endpoints create and update dashboard ‑ LookerNodeSDK Dashboard endpoints create and update dashboard
LookerNodeSDK Dashboard endpoints search_dashboards ‑ LookerNodeSDK Dashboard endpoints search_dashboards
LookerNodeSDK Datagroups gets all datagroups ‑ LookerNodeSDK Datagroups gets all datagroups
LookerNodeSDK Node environment no INI ‑ LookerNodeSDK Node environment no INI
LookerNodeSDK PUT smoke test set default color collection ‑ LookerNodeSDK PUT smoke test set default color collection
LookerNodeSDK Query calls create and run query ‑ LookerNodeSDK Query calls create and run query
LookerNodeSDK Query calls parses a query with no results ‑ LookerNodeSDK Query calls parses a query with no results
LookerNodeSDK Query calls run_inline_query ‑ LookerNodeSDK Query calls run_inline_query
LookerNodeSDK Theme validate_theme returns ok on valid template ‑ LookerNodeSDK Theme validate_theme returns ok on valid template
LookerNodeSDK Theme validate_theme throws error with details ‑ LookerNodeSDK Theme validate_theme throws error with details
…

BrowserTransport accepted response is ok if retries are exceeded ‑ BrowserTransport accepted response is ok if retries are exceeded
BrowserTransport does not exceed retries ‑ BrowserTransport does not exceed retries
BrowserTransport retries can cancelled ‑ BrowserTransport retries can cancelled
BrowserTransport retries can error out ‑ BrowserTransport retries can error out
BrowserTransport retries can have a custom override ‑ BrowserTransport retries can have a custom override
BrowserTransport retries responses with retry status codes ‑ BrowserTransport retries responses with retry status codes
BrowserTransport timeout and cancel cancels in 250 ms ‑ BrowserTransport timeout and cancel cancels in 250 ms
BrowserTransport timeout and cancel completes before 1 second cancel ‑ BrowserTransport timeout and cancel completes before 1 second cancel
BrowserTransport timeout and cancel does not timeout by default ‑ BrowserTransport timeout and cancel does not timeout by default
BrowserTransport timeout and cancel times out in 1 second ‑ BrowserTransport timeout and cancel times out in 1 second
…

This pull request removes 4 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.

LookerNodeSDK paging alpha pageAll all_dashboards pageAll returns non-paged results ‑ LookerNodeSDK paging alpha pageAll all_dashboards pageAll returns non-paged results
LookerNodeSDK paging alpha pageAll search_dashboard ‑ LookerNodeSDK paging alpha pageAll search_dashboard
LookerNodeSDK paging alpha pager getRel can override limit and offset ‑ LookerNodeSDK paging alpha pager getRel can override limit and offset
LookerNodeSDK paging alpha pager observers can be chained ‑ LookerNodeSDK paging alpha pager observers can be chained

BrowserTransport timeout and cancel cancels in 250 ms ‑ BrowserTransport timeout and cancel cancels in 250 ms

♻️ This comment has been updated with latest results.

github-actions · 2024-08-26T17:02:28Z

APIX Tests

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 08fc612. ± Comparison against base commit cb1e948.

♻️ This comment has been updated with latest results.

github-actions · 2024-08-26T17:05:02Z

Codegen Tests

459 tests +41 423 ✅ +23 48s ⏱️ +5s
21 suites + 3 36 💤 +18
1 files ± 0 0 ❌ ± 0

Results for commit 08fc612. ± Comparison against base commit cb1e948.

This pull request removes 17 and adds 58 tests. Note that renamed tests count towards both.

c# generator comment header ‑ c# generator comment header
c# generator deprecated method with deprecated params ‑ c# generator deprecated method with deprecated params
c# generator methods generates a method with a single return type ‑ c# generator methods generates a method with a single return type
c# generator methods generates a method with multiple return types ‑ c# generator methods generates a method with multiple return types
c# generator methods noComment method with multiple return types ‑ c# generator methods noComment method with multiple return types
c# generator reserved words readonly ‑ c# generator reserved words readonly
c# generator reserved words string ‑ c# generator reserved words string
c# generator summarizes one line ‑ c# generator summarizes one line
c# generator summarizes two lines ‑ c# generator summarizes two lines
c# generator type creation enum declaration with reserved words ‑ c# generator type creation enum declaration with reserved words
…

Look# comment header ‑ Look# comment header
Look# deprecated method with deprecated params ‑ Look# deprecated method with deprecated params
Look# methods generates a method with a single return type ‑ Look# methods generates a method with a single return type
Look# methods generates a method with multiple return types ‑ Look# methods generates a method with multiple return types
Look# methods noComment method with multiple return types ‑ Look# methods noComment method with multiple return types
Look# reserved words readonly ‑ Look# reserved words readonly
Look# reserved words string ‑ Look# reserved words string
Look# summarizes one line ‑ Look# summarizes one line
Look# summarizes two lines ‑ Look# summarizes two lines
Look# type creation enum declaration with reserved words ‑ Look# type creation enum declaration with reserved words
…

This pull request removes 2 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.

c# generator type creation enum declaration with reserved words ‑ c# generator type creation enum declaration with reserved words
specConverter includeVersion includes 4.0 ‑ specConverter includeVersion includes 4.0

Look# type creation enum declaration with reserved words ‑ Look# type creation enum declaration with reserved words

This pull request skips 20 and un-skips 1 tests.

fetch operations can login ‑ fetch operations can login
fetch operations defaults lookerVersion when server is not responding ‑ fetch operations defaults lookerVersion when server is not responding
fetch operations get versions ‑ fetch operations get versions
fetch operations gets lookerVersion with good server ‑ fetch operations gets lookerVersion with good server
fetch operations gets lookerVersion with supplied versions ‑ fetch operations gets lookerVersion with supplied versions
fetch operations gets version info ‑ fetch operations gets version info
fetch operations logConvertSpec ‑ fetch operations logConvertSpec
sdkModels fromSpec method and type xrefs custom types determines parent type of enum types ‑ sdkModels fromSpec method and type xrefs custom types determines parent type of enum types
sdkModels fromSpec request type determination detects recursive types ‑ sdkModels fromSpec request type determination detects recursive types
spec conversion collectionFormat to style ‑ spec conversion collectionFormat to style
…

Kotlin generator types special needs ‑ Kotlin generator types special needs

♻️ This comment has been updated with latest results.

drstrangelooker

Looks LGTM To Me

prescottbreeden

I would break this CL up, it is too large to critically review. I lost my place and on second review trying to use the viewed option is not tenable with this many files.

this is an excellent POC, I would now use this as your template to make the changes first to Prettier, and then perhaps node 22, and then your fetch updates.

I will leave this as non-blocking

prescottbreeden · 2024-09-10T17:42:55Z

jest.setup.js

@@ -32,6 +32,7 @@ const ResizeObserver = require('resize-observer-polyfill');
 require('@testing-library/jest-dom');
 require('jest-canvas-mock');
 require('jest-styled-components');
+// require('jest-environment-node');


Yes. I will have a cleanup pass in another PR that removes stale commented-out code. The prettier changes had to be made to get this PR to pass CI after code was taken from internal changes.

packages/sdk-codegen-scripts/src/fetchSpec.spec.ts

jkaster · 2024-09-10T18:37:21Z

packages/sdk-codegen-scripts/src/prettify.spec.ts

@@ -2,7 +2,7 @@

 MIT License

- Copyright (c) 2021 Looker Data Sciences, Inc.
+ Copyright (c) 2023 Looker Data Sciences, Inc.


weird. This was not a renamed file but a new file.

jkaster · 2024-09-10T18:38:09Z

packages/sdk-codegen-scripts/src/prettify.ts

@@ -35,18 +35,15 @@ const prettierTs: prettier.Options = {
  semi: true,
  singleQuote: true,
  trailingComma: 'es5',
-  arrowParens: 'always',
+  arrowParens: 'avoid',


the primary cause of all the file reformatting in this PR. Required for compatibility with internal versions of the SDK.

jkaster · 2024-09-10T18:39:45Z

packages/sdk-codegen-utils/src/utils.spec.ts

@@ -2,7 +2,7 @@

 MIT License

- Copyright (c) 2021 Looker Data Sciences, Inc.
+ Copyright (c) 2023 Looker Data Sciences, Inc.


another file rename that wasn't

jkaster · 2024-09-10T18:42:56Z

packages/sdk-node/jest.config.js

@@ -2,7 +2,7 @@

 MIT License

- Copyright (c) 2021 Looker Data Sciences, Inc.
+ Copyright (c) 2020 Looker Data Sciences, Inc.


not a rename

🤖 I have created a release *beep* *boop* --- <details><summary>api-explorer: 0.9.65</summary> ## [0.9.65](api-explorer-v0.9.64...api-explorer-v0.9.65) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.31 to 0.1.32 * @looker/extension-utils bumped from 0.1.41 to 0.1.42 * @looker/run-it bumped from 0.9.64 to 0.9.65 * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-codegen bumped from 21.9.0 to 21.9.1 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 * devDependencies * @looker/sdk-codegen-scripts bumped from 21.5.21 to 21.5.22 * @looker/sdk-node bumped from 24.14.0 to 24.16.0 </details> <details><summary>code-editor: 0.1.32</summary> ## [0.1.32](code-editor-v0.1.31...code-editor-v0.1.32) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * devDependencies * @looker/sdk-codegen bumped from 21.9.0 to 21.9.1 </details> <details><summary>@looker/extension-api-explorer: 22.21.22</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/api-explorer bumped from 0.9.64 to 0.9.65 * @looker/extension-sdk bumped from 24.14.0 to 24.16.0 * @looker/extension-sdk-react bumped from 24.14.0 to 24.16.0 * @looker/extension-utils bumped from 0.1.41 to 0.1.42 * @looker/run-it bumped from 0.9.64 to 0.9.65 * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-codegen bumped from 21.9.0 to 21.9.1 </details> <details><summary>extension-playground: 1.0.22</summary> ## [1.0.22](extension-playground-v1.0.21...extension-playground-v1.0.22) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.14.0 to 24.16.0 * @looker/extension-sdk-react bumped from 24.14.0 to 24.16.0 * @looker/sdk bumped from 24.14.0 to 24.16.0 </details> <details><summary>extension-tile-playground: 1.1.9</summary> ## [1.1.9](extension-tile-playground-v1.1.8...extension-tile-playground-v1.1.9) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.14.0 to 24.16.0 * @looker/extension-sdk-react bumped from 24.14.0 to 24.16.0 * @looker/sdk bumped from 24.14.0 to 24.16.0 </details> <details><summary>extension-utils: 0.1.42</summary> ## [0.1.42](extension-utils-v0.1.41...extension-utils-v0.1.42) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.31 to 0.1.32 * @looker/extension-sdk bumped from 24.14.0 to 24.16.0 * @looker/extension-sdk-react bumped from 24.14.0 to 24.16.0 * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 </details> <details><summary>hackathon: 22.21.24</summary> ## [22.21.24](hackathon-v22.21.23...hackathon-v22.21.24) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.31 to 0.1.32 * @looker/extension-sdk bumped from 24.14.0 to 24.16.0 * @looker/extension-sdk-react bumped from 24.14.0 to 24.16.0 * @looker/extension-utils bumped from 0.1.41 to 0.1.42 * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 * @looker/wholly-artifact bumped from 0.1.22 to 0.1.23 </details> <details><summary>run-it: 0.9.65</summary> ## [0.9.65](run-it-v0.9.64...run-it-v0.9.65) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.31 to 0.1.32 * @looker/extension-utils bumped from 0.1.41 to 0.1.42 * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-codegen bumped from 21.9.0 to 21.9.1 * @looker/sdk-codegen-utils bumped from 21.0.11 to 21.0.12 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 </details> <details><summary>sdk-codegen: 21.9.1</summary> ## [21.9.1](sdk-codegen-v21.9.0...sdk-codegen-v21.9.1) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 * devDependencies * @looker/sdk-codegen-utils bumped from 21.0.11 to 21.0.12 </details> <details><summary>sdk-codegen-scripts: 21.5.22</summary> ## [21.5.22](sdk-codegen-scripts-v21.5.21...sdk-codegen-scripts-v21.5.22) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-codegen bumped from 21.9.0 to 21.9.1 * @looker/sdk-codegen-utils bumped from 21.0.11 to 21.0.12 * @looker/sdk-node bumped from 24.14.0 to 24.16.0 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 </details> <details><summary>sdk-codegen-utils: 21.0.12</summary> ## [21.0.12](sdk-codegen-utils-v21.0.11...sdk-codegen-utils-v21.0.12) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * devDependencies * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 * @looker/sdk bumped from 24.12.1 to 24.16.0 * @looker/sdk-node bumped from 24.12.1 to 24.16.0 </details> <details><summary>sdk-rtl: 21.6.2</summary> ## [21.6.2](sdk-rtl-v21.6.1...sdk-rtl-v21.6.2) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) </details> <details><summary>wholly-artifact: 0.1.23</summary> ## [0.1.23](wholly-artifact-v0.1.22...wholly-artifact-v0.1.23) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 * @looker/sdk bumped from 24.14.0 to 24.16.0 * devDependencies * @looker/sdk-node bumped from 24.14.0 to 24.16.0 </details> <details><summary>wholly-sheet: 0.5.61</summary> ## [0.5.61](wholly-sheet-v0.5.60...wholly-sheet-v0.5.61) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 * devDependencies * @looker/sdk-node bumped from 24.14.0 to 24.16.0 </details> <details><summary>sdk-codegen-all: 24.16.0</summary> ## [24.16.0](sdk-codegen-all-v24.14.0...sdk-codegen-all-v24.16.0) (2024-09-11) ### Features * generate SDKs for Looker 24.16 ([#1499](#1499)) ([109839d](109839d)) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) </details> <details><summary>looker_sdk: 24.16.0</summary> ## [24.16.0](looker_sdk-v24.14.0...looker_sdk-v24.16.0) (2024-09-11) ### Features * generate SDKs for Looker 24.16 ([#1499](#1499)) ([109839d](109839d)) </details> <details><summary>embed-components: 24.16.0</summary> ## [24.16.0](embed-components-v24.14.0...embed-components-v24.16.0) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/embed-services bumped from 24.14.0 to 24.16.0 * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 * devDependencies * @looker/sdk-node bumped from 24.14.0 to 24.16.0 </details> <details><summary>embed-services: 24.16.0</summary> ## [24.16.0](embed-services-v24.14.0...embed-services-v24.16.0) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 * @looker/sdk bumped from 24.14.0 to 24.16.0 * devDependencies * @looker/sdk-node bumped from 24.14.0 to 24.16.0 </details> <details><summary>extension-sdk: 24.16.0</summary> ## [24.16.0](extension-sdk-v24.14.0...extension-sdk-v24.16.0) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 </details> <details><summary>extension-sdk-react: 24.16.0</summary> ## [24.16.0](extension-sdk-react-v24.14.0...extension-sdk-react-v24.16.0) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 </details> <details><summary>sdk: 24.16.0</summary> ## [24.16.0](sdk-v24.14.0...sdk-v24.16.0) (2024-09-11) ### Features * generate SDKs for Looker 24.16 ([#1499](#1499)) ([109839d](109839d)) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 </details> <details><summary>sdk-node: 24.16.0</summary> ## [24.16.0](sdk-node-v24.14.0...sdk-node-v24.16.0) (2024-09-11) ### Bug Fixes * Remove the requests package from the TypeScript SDK ([#1491](#1491)) ([670377c](670377c)), closes [#1439](#1439) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.14.0 to 24.16.0 * @looker/sdk-rtl bumped from 21.6.1 to 21.6.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

jkaster added 22 commits August 9, 2024 17:13

fix: many updates for the TypeScript SDK

97419fb

Includes removal of the deprecated node Request package WIP, build is still broken on extension SDKs

some lint updates, still broken branch

658d90f

some lint updates, still broken branch

0cc4215

fixed extension sdk initialization

5d7a44d

major refactor for TS SDK streaming

e53807d

fixing build issues

cc95359

more tweaks

64d39b3

Merge branch 'main' into fetcher

9893483

more tweaks

797630a

now trying to get login to work again

7a1039f

still fighting self-signed cert issues

8046d13

still fighting self-signed cert issues

f399f12

now working on auth issues

9c90b05

most transport variances are working

9d2cbe3

fixing up integration tests

71ae576

ref node 22.x in workflows

4be049c

skipping some problematic jest tests when run from command line

c6af0d7

reformatter with prettier is working again

15d9cb2

NodeJS streaming is working again

a6f1d5a

updated the TS streaming example and examples index

04ab2bc

Updated readmes also

jest polyfill for AbortSignal.timeout

7e772c8

fetchspec test uses timeout override

5a50660

jkaster requested a review from a team as a code owner August 26, 2024 16:59

github-advanced-security bot found potential problems Aug 26, 2024

View reviewed changes

jest.config.js Fixed Show fixed Hide fixed

packages/sdk-node/src/nodeTransport.ts Fixed Show fixed Hide fixed

jkaster added 3 commits August 26, 2024 10:22

run prettier on all files

b1361d6

working on some CI issues

151627e

working on some CI issues

f5f1a8a

jkaster added 11 commits September 6, 2024 16:02

fix node test config path

1ed15e8

another path attempt

8da26d0

yet another path attempt

d9ca13a

use env=node instead!

8580edd

GitHub action path issues are insane

c38b747

run node tests in parallel again

c0bbc9d

try to log full error

3418018

implementing my OWN node test suite

a415abf

using node test runner

2215353

full port methods.spec.ts to sdk.test.ts

dfcf52a

update TS sdk readmes

052069e

jkaster requested review from treshugart, bryans99, josephaxisa and prescottbreeden September 10, 2024 01:31

jkaster added 4 commits September 9, 2024 18:47

test failures in CI. Again.

cd032fe

test failures in CI. Again.

bea1ea1

correct beforeAll and afterAll synonyms

d4b33e3

another test attempt

08fc612

drstrangelooker approved these changes Sep 10, 2024

View reviewed changes

prescottbreeden reviewed Sep 10, 2024

View reviewed changes

jkaster commented Sep 10, 2024

View reviewed changes

jkaster merged commit 670377c into main Sep 10, 2024
22 checks passed

jkaster deleted the fetcher branch September 10, 2024 18:54

looker-open-source-automation-bot mentioned this pull request Sep 10, 2024

chore: release main #1494

Merged

jkaster mentioned this pull request Sep 12, 2024

Migrate away from the request module #175

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Remove the requests package from the TypeScript SDK #1491

fix: Remove the requests package from the TypeScript SDK #1491

jkaster commented Aug 26, 2024

github-actions bot commented Aug 26, 2024 •

edited

Loading

github-actions bot commented Aug 26, 2024 •

edited

Loading

github-actions bot commented Aug 26, 2024 •

edited

Loading

drstrangelooker left a comment

prescottbreeden left a comment

prescottbreeden Sep 10, 2024

jkaster Sep 10, 2024

jkaster Sep 10, 2024

jkaster Sep 10, 2024

jkaster Sep 10, 2024

jkaster Sep 10, 2024

fix: Remove the requests package from the TypeScript SDK #1491

fix: Remove the requests package from the TypeScript SDK #1491

Conversation

jkaster commented Aug 26, 2024

github-actions bot commented Aug 26, 2024 • edited Loading

Typescript Tests

github-actions bot commented Aug 26, 2024 • edited Loading

APIX Tests

github-actions bot commented Aug 26, 2024 • edited Loading

Codegen Tests

drstrangelooker left a comment

Choose a reason for hiding this comment

prescottbreeden left a comment

Choose a reason for hiding this comment

prescottbreeden Sep 10, 2024

Choose a reason for hiding this comment

jkaster Sep 10, 2024

Choose a reason for hiding this comment

jkaster Sep 10, 2024

Choose a reason for hiding this comment

jkaster Sep 10, 2024

Choose a reason for hiding this comment

jkaster Sep 10, 2024

Choose a reason for hiding this comment

jkaster Sep 10, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 26, 2024 •

edited

Loading

github-actions bot commented Aug 26, 2024 •

edited

Loading

github-actions bot commented Aug 26, 2024 •

edited

Loading