fix: Remove the requests package from the TypeScript SDK

.github/workflows/apix-ci.yml

@@ -39,7 +39,7 @@ jobs:
       matrix:
         os:
           - ubuntu
-        node-version: [18.x]
+        node-version: [22.x]
 
     steps:
       - name: Cancel Previous Runs

.github/workflows/codegen-ci.yml

@@ -73,7 +73,7 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 22.x
 
       - name: Install dependencies
         run: |

.github/workflows/hackathon-ci.yml

@@ -33,7 +33,7 @@ jobs:
       matrix:
         os:
           - ubuntu
-        node-version: [18.x]
+        node-version: [22.x]
 
     steps:
       - name: Cancel Previous Runs

.github/workflows/lerna-publish.yml

@@ -56,7 +56,7 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 22.x
           registry-url: https://wombat-dressing-room.appspot.com
 
       - name: Install dependencies and build

.github/workflows/resources-ci.yml

@@ -38,7 +38,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 22.x
 
       - name: Install Dependencies
         run: |

.github/workflows/tssdk-ci.yml

@@ -43,7 +43,7 @@ jobs:
       matrix:
         os:
           - ubuntu
-        node-version: [18.x, 20.x]
+        node-version: [20.x, 22.x]
 
     steps:
       - name: Cancel Previous Runs
@@ -122,7 +122,7 @@ jobs:
     runs-on: ${{ matrix.os }}-latest
     strategy:
       matrix:
-        node-version: [18.x, 20.x]
+        node-version: [20.x, 22.x]
         os:
           - ubuntu
         looker: ${{ fromJson(needs.setup.outputs.matrix_json) }}

.prettierignore

@@ -6,4 +6,5 @@
 **/storybook-static
 **/test/output
 **/.eslintrc
-*.lock
+*.lock
+bin/**

.prettierrc.js

@@ -4,5 +4,6 @@ const config = {
   semi: true,
   singleQuote: true,
   trailingComma: 'es5',
+  arrowParens: 'avoid',
 };
 module.exports = config;

bin/looker-resources-index/package.json

@@ -16,7 +16,7 @@
   "author": "Looker",
   "license": "MIT",
   "devDependencies": {
-    "@types/node": "14.18.63",
-    "typescript": "5.1.6"
+    "@types/node": "22.5.0",
+    "typescript": "5.5.4"
   }
 }

examples/typescript/README.md

@@ -33,10 +33,6 @@ These examples assume that a `looker.ini` has been created in the root of the re
 
 Some other dependencies may be required for the projects to build and run correctly on your local clone.
 
-```bash
-yarn install @types/readable-stream @types/request @types/request-promise-native -D
-```
-
 ## TypeScript SDK packages
 
 The Looker TypeScript SDK has different packages to prevent node dependencies being linked into browser usage of the SDK (the node dependencies are not available in the browser and can cause compilation errors). There are three packages for the Typescript SDK available on npm:

examples/typescript/downloadTile.ts

@@ -25,14 +25,13 @@
  */
 
 import * as fs from 'fs';
-import { Readable } from 'stream';
+import { Looker40SDK as LookerSDK, Looker40SDKStream } from '@looker/sdk';
+import type { IDashboardElement, IRequestRunQuery } from '@looker/sdk';
 import {
-  Looker40SDK as LookerSDK,
-  IDashboardElement,
-  IRequestRunQuery,
-  Looker40SDKStream,
-} from '@looker/sdk';
-import { NodeSettingsIniFile, NodeSession } from '@looker/sdk-node';
+  NodeSettingsIniFile,
+  NodeSession,
+  createWritableStream,
+} from '@looker/sdk-node';
 import {
   getDashboard,
   getDashboardTile,
@@ -77,8 +76,8 @@ const getParams = () => {
 
 /**
  * Is this format renderable?
- * @param {string} format to render
- * @returns {boolean} true if render_task can be used for this format
+ * @param format to render
+ * @returns true if render_task can be used for this format
  */
 const isRenderable = (format: string) => {
   format = format.toLowerCase();
@@ -87,12 +86,12 @@ const isRenderable = (format: string) => {
 
 /**
  * Renders a dashboard tile's query as PNG or JPG
- * @param {LookerSDK} sdk object to use
- * @param {IDashboardElement} tile to render (using query_id)
- * @param {string} format either png or jpg
- * @param {number} width defaults to 640
- * @param {number} height defaults to 480
- * @returns {Promise<string>} name of downloaded file (undefined on failure)
+ * @param sdk object to use
+ * @param tile to render (using query_id)
+ * @param format either png or jpg
+ * @param width defaults to 640
+ * @param height defaults to 480
+ * @returns name of downloaded file (undefined on failure)
  *
  * **Note:** run_query can also be used for PNG and JPG output, but this function will show an elapsed time ticker via
  * the `waitForRender()` callback as the render is progressing
@@ -113,10 +112,11 @@ const renderTile = async (
     throw new Error(`Could not create a render task for ${tile.title}`);
   }
 
+  // eslint-disable-next-line testing-library/render-result-naming-convention
   const result = await waitForRender(sdk, task.id!);
   if (result) {
     fileName = `${tile.title}.${format}`;
-    fs.writeFile(fileName, result, 'binary', (err) => {
+    fs.writeFile(fileName, result, 'binary', err => {
       if (err) {
         fileName = undefined; // no file was created
         throw err;
@@ -128,48 +128,40 @@ const renderTile = async (
 
 /**
  * Use the streaming SDK to download a tile's query
- * @param {LookerSDK} sdk to use
- * @param {IDashboardElement} tile to download
- * @param {string} format to download
- * @returns {Promise<string>} name of downloaded file (undefined on failure)
+ * @param sdk to use
+ * @param tile to download
+ * @param format to download
+ * @returns name of downloaded file (undefined on failure)
  */
 const downloadTileAs = async (
   sdk: LookerSDK,
   tile: IDashboardElement,
   format: string
 ) => {
-  let fileName;
-  fileName = `${tile.title}.${format}`;
+  const fileName = `${tile.title}.${format}`;
 
-  const writer = fs.createWriteStream(fileName);
+  const writer = createWritableStream(fs.createWriteStream(fileName));
   const request: IRequestRunQuery = {
     result_format: format,
     query_id: tile.query_id!,
     // apply_formatting: true,
     // apply_vis: true
   };
   const sdkStream = new Looker40SDKStream(sdk.authSession);
-  await sdkStream.run_query(async (readable: Readable) => {
-    return new Promise<any>((resolve, reject) => {
-      readable
-        .pipe(writer)
-        .on('error', () => {
-          fileName = undefined;
-          throw reject;
-        })
-        .on('finish', resolve);
-    });
+  await sdkStream.run_query(async (response: Response) => {
+    await response.body.pipeTo(writer);
+    return 'streamed';
   }, request);
 
   return fileName;
 };
 
 /**
  * Download a dashboard tile in any of its supported formats
- * @param {LookerSDK} sdk initialized Looker SDK
- * @param {IDashboardElement} tile Dashboard tile to render
- * @param {string} format format of rendering
- * @returns {Promise<undefined | string>} Name of file downloaded
+ * @param sdk initialized Looker SDK
+ * @param tile Dashboard tile to render
+ * @param format format of rendering
+ * @returns Name of file downloaded
  */
 const downloadTile = async (
   sdk: LookerSDK,