Simulator exit #368
Open
Simulator exit #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update code from upstream repository https://github.com/lowRISC/opentitan to revision a78922f14a8cc20c7ee569f322a04626f2ac6127 Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
marnovandermaas
force-pushed
the
simulator_exit
branch
from
4adc54e to
a12833b
Compare
|
One thing to note with this PR is that the magic string will exit the simulator on any of the UARTS including the RS-485 one. I don't think that's a problem, but if it is we can parametrise the |
alees24
approved these changes
Dec 10, 2024
|
As discussed in person, and annotated here just for future consideration....a simple register/IP block on the Sonata bus that provided power down/suspend/reset on a physical system (we still have a requirement for a reset block) could also provide shutdown in simulation more elegantly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the simulator to exit when the following magic string is sent over the UART:
Safe to exit simulator.\xd8\xaf\xfb\xa0\xc7\xe1\xa9\xd7Closes: #365