Sync main to release #797
Merged
Sync main to release #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: fix explorer API url to verify contracts
refactor: [I-02] Update is valid nonce
test: add tests for LSP1 Type IDs
…vent data loss (#784) * fix: return raw bytes in LSP6, not decoded as `bytes` * test: adjust tests to decode `bytes` / `bytes[]` first before decoding target type * test: add more tests for return values of `executeRelayCall` and `executeRelayCallBatch`
…SP6KeyManager (#777) * fix: allow to set 20/21 bytes under LSP17Extension data key in LSP6KeyManager * test: add necessary tests * chore: run prettier * Update contracts/LSP6KeyManager/LSP6Modules/LSP6SetDataModule.sol Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com> * test: test error for different controller permissions --------- Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com> Co-authored-by: CJ42 <cavallerajean@gmail.com>
* refactor: Prevent casting data > 20 bytes for LSP17Extensions * test: add necessary tests * chore: apply suggested changes --------- Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
….)` in LSP14 (#775) * fix: reset `_renounceOwnershipStartedAt` on acceptOwnership(..) * test: add foundry test * chore: run format on foundry test * chore: add suggested changes --------- Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
…ship` (#783) * refactor: notify when owner uses `renounceOwnership` * test: add tests for `renounceOwnership()` LSP1 hook
…00000` (#776) * refactor: improve empty call check * test: add extra sanity tests for permission checks on value transfer * test: add Foundry tests for checking callTypes verification * refactor: check for callTypes on empty calls * test: add Foundry fuzzing tests for calltypes check against empty calls * test: add more Foundry tests to check against allowing `bytes4(0)` graffiti calls * docs: update LSP6 docs for internal function --------- Co-authored-by: CJ42 <cavallerajean@gmail.com>
…update version for (#785) * chore: bootstrap releases for path: . * build: add `Version.sol` as extra file to update
Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
* refactor: add lsp1 data in ownership function hooks * test: resolve failing tests to latest behavior * refactor: add the hooks in LSP14 and LSP9 * test: resolve lsp1 failing tests * chore: delete renounceOwnershipStartedAt in acceptOwnership --------- Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
* build: add `Version` contract in artifact list * refactor: use `VERSION` as constant in LSP0, 1 Delegate, 6 and 9 * docs: update auto generated docs * fix: add missing `VERSION` in `UniversalProfileInit` * refactor: re-introduce `Version.sol` contract * fix: add missing `LSP17Extension` in inheritance of `OnERC721ReceivedExtension`
* docs: Improve natspec for LSP0 * chore: add suggested changes * docs: mark Natspec comments in `@custom` tags --------- Co-authored-by: CJ42 <cavallerajean@gmail.com> Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
skimaharvey
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
Sync
developwithmainbranch to release new version of lsp-smart-contracts (should be a patch version v0.12.1 normally as commits include mainly fixes + miscellaneous (refactor, chore)).