Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main to release #797

Merged
merged 26 commits into from
Nov 7, 2023
Merged

Sync main to release #797

merged 26 commits into from
Nov 7, 2023

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    b6a0193 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge pull request #774 from lukso-network/ci/verify

    build: fix explorer API url to verify contracts
    CJ42 authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    df653c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    d20f17d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f1c4da View commit details
    Browse the repository at this point in the history
  3. Merge pull request #782 from lukso-network/update-isValidNonce

    refactor: [I-02] Update is valid nonce
    CJ42 authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    34fb918 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b61c7f0 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #781 from lukso-network/DEV-8861

    test: add tests for LSP1 Type IDs
    CJ42 authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    dceee16 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. fix: [L-01] Return bytes directly in LSP6 _executePayload, to pre…

    …vent data loss (#784)
    
    * fix: return raw bytes in LSP6, not decoded as `bytes`
    
    * test: adjust tests to decode `bytes` / `bytes[]` first before decoding target type
    
    * test: add more tests for return values of `executeRelayCall` and `executeRelayCallBatch`
    CJ42 authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    fd23a24 View commit details
    Browse the repository at this point in the history
  2. fix: [M-03] allow setting 21 bytes under LSP17Extension data key in L…

    …SP6KeyManager (#777)
    
    * fix: allow to set 20/21 bytes under LSP17Extension data key in LSP6KeyManager
    
    * test: add necessary tests
    
    * chore: run prettier
    
    * Update contracts/LSP6KeyManager/LSP6Modules/LSP6SetDataModule.sol
    
    Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
    
    * test: test error for different controller permissions
    
    ---------
    
    Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
    Co-authored-by: CJ42 <cavallerajean@gmail.com>
    3 people authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8f1fb95 View commit details
    Browse the repository at this point in the history
  3. refactor: Prevent casting LSP17 Data shorter than 20 bytes (#778)

    * refactor: Prevent casting data > 20 bytes for LSP17Extensions
    
    * test: add necessary tests
    
    * chore: apply suggested changes
    
    ---------
    
    Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
    YamenMerhi and CJ42 authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d6356a7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e33477e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aa30637 View commit details
    Browse the repository at this point in the history
  6. fix: [M-02] reset _renounceOwnershipStartedAt on `acceptOwnership(.…

    ….)` in LSP14 (#775)
    
    * fix: reset `_renounceOwnershipStartedAt` on acceptOwnership(..)
    
    * test: add foundry test
    
    * chore: run format on foundry test
    
    * chore: add suggested changes
    
    ---------
    
    Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
    YamenMerhi and CJ42 authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5d8a7af View commit details
    Browse the repository at this point in the history
  7. refactor: [M-05] notify owner via LSP1 when confirming `renounceOwner…

    …ship` (#783)
    
    * refactor: notify when owner uses `renounceOwnership`
    
    * test: add tests for `renounceOwnership()` LSP1 hook
    b00ste authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    63c06d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. fix: [M-04 + L-02] improve empty call type checks for selector `0x000…

    …00000` (#776)
    
    * refactor: improve empty call check
    
    * test: add extra sanity tests for permission checks on value transfer
    
    * test: add Foundry tests for checking callTypes verification
    
    * refactor: check for callTypes on empty calls
    
    * test: add Foundry fuzzing tests for calltypes check against empty calls
    
    * test: add more Foundry tests to check against allowing `bytes4(0)` graffiti calls
    
    * docs: update LSP6 docs for internal function
    
    ---------
    
    Co-authored-by: CJ42 <cavallerajean@gmail.com>
    b00ste and CJ42 authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    78bb1e7 View commit details
    Browse the repository at this point in the history
  2. chore: bootstrap releases for path: . + add Version.sol in file to …

    …update version for (#785)
    
    * chore: bootstrap releases for path: .
    
    * build: add `Version.sol` as extra file to update
    CJ42 authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c0090c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Configuration menu
    Copy the full SHA
    bff93e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1574a8 View commit details
    Browse the repository at this point in the history
  3. refactor: use gas estimate in deployements scripts (#792)

    Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
    skimaharvey and CJ42 authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a855dd1 View commit details
    Browse the repository at this point in the history
  4. chore: adjust Natspec comments + use mixedCase name for modifier (#786

    )
    
    * docs: adjust missing Natspec comments
    
    * chore: write `modifer` in mixedCase according to Solidity style guide
    
    * docs: imporve grammar in Natspec docs for `_nonReentrantBefore`
    CJ42 authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e7ef125 View commit details
    Browse the repository at this point in the history
  5. refactor: add lsp1 data in ownership function hooks (#789)

    * refactor: add lsp1 data in ownership function hooks
    
    * test: resolve failing tests to latest behavior
    
    * refactor: add the hooks in LSP14 and LSP9
    
    * test: resolve lsp1 failing tests
    
    * chore: delete renounceOwnershipStartedAt in acceptOwnership
    
    ---------
    
    Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
    YamenMerhi and CJ42 authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    0b27572 View commit details
    Browse the repository at this point in the history
  6. refactor: use VERSION instead of version (#791)

    * build: add `Version` contract in artifact list
    
    * refactor: use `VERSION` as constant in LSP0, 1 Delegate, 6 and 9
    
    * docs: update auto generated docs
    
    * fix: add missing `VERSION` in `UniversalProfileInit`
    
    * refactor: re-introduce `Version.sol` contract
    
    * fix: add missing `LSP17Extension` in inheritance of `OnERC721ReceivedExtension`
    CJ42 authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    acf0a72 View commit details
    Browse the repository at this point in the history
  7. refactor: generate local links for @param & @return (#793)

    * refactor: local links for `@param` & `@return`
    
    * docs: update auto-generated docs
    b00ste authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d3f26ea View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4ff7b6f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9ba0fcd View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. docs: Improve natspec for LSP0 (#794)

    * docs: Improve natspec for LSP0
    
    * chore: add suggested changes
    
    * docs: mark Natspec comments in `@custom` tags
    
    ---------
    
    Co-authored-by: CJ42 <cavallerajean@gmail.com>
    Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
    3 people authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    6594f67 View commit details
    Browse the repository at this point in the history