Workload entry expiry features #96
Conversation
maia-iyer
force-pushed
the
workload-entry-expiry-features
branch
2 times, most recently
from
23c839f
to
bbcc590
Compare
maia-iyer
force-pushed
the
workload-entry-expiry-features
branch
from
265d67d
to
3100b66
Compare
| }); | ||
| } | ||
|
|
||
| isValidJSTime(seconds) { |
There was a problem hiding this comment.
this is not just isValidJSTime since it asserts >0, so this is more specific to the usecase, so isValidExpiryTime may be more appropriate, also while checking this, it may be good to also see if there's an upper limit on SPIRE type as well, i think it probably is 64 bit so just verify that that upper bound is checked too
There was a problem hiding this comment.
so from whatever I could find/tell, you're right, that SPIRE deals with 64bit for time. Then, the upper limit on SPIRE is a bit larger (about .5e15) than the JS upper bound on dates - is this still then a necessary check?
| @@ -115,6 +115,9 @@ class SpiffeHelper extends Component { | |||
| // n:1, this would reduce the total cost. This may be useful when | |||
| // performance is impacted. | |||
| getAgentsEntries (agents, entries) { | |||
| if (typeof entries === 'undefined') { | |||
| return {}; | |||
There was a problem hiding this comment.
im kind of curious what triggered this, this is actually a fault in the caller making this call, so we should really resolve that instead, can we also console.log a message here, and be like "getAgentEntries: this should not happen, entries undefined"
There was a problem hiding this comment.
should I remove the check then? I found the error (in dashboard when there are no workload entries) and have added a todo statement in the relevant line of code in dashbard/agents-dashboard-table.js
maia-iyer
force-pushed
the
workload-entry-expiry-features
branch
from
8273a34
to
ef05c9f
Compare
lumjjb
force-pushed
the
workload-entry-expiry-features
branch
from
722f5db
to
e2572b7
Compare
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
lumjjb
force-pushed
the
workload-entry-expiry-features
branch
from
e2572b7
to
58056c6
Compare
editing entry-create form for multiple entry formats and warnings on already expired entries or data that causes no expiry date