[To be closed] - Workload entry expiry features #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
lumjjb
commented
Aug 27, 2021
| }); | ||
| } | ||
|
|
||
| isValidExpiryTime(seconds) { | ||
| const JSMaxSafeTime = 8640000000000 // JS cannot represent times safely larger than this |
There was a problem hiding this comment.
please add reference to this
| this.expiryTimeUpdate(seconds) | ||
| } | ||
|
|
||
| // TODO some odd behavior with dates like February 33 exists |
There was a problem hiding this comment.
issue needs validation
| return d instanceof Date && isFinite(d) | ||
| } | ||
|
|
||
| updateValidDateAndTime(d, t) { |
There was a problem hiding this comment.
all setStates should be done atomically if possible
| <div role="alert"> | ||
| <p className="failed-message">Warning: expiry time either in invalid format, is negative, or is too large. Submitting this time may result in undefined behavior.</p> | ||
| {this.state.expiryOption === "Seconds Since Epoch" && this.state.expiryUnsafe && | ||
| <p className="failed-message">Seconds must be positive and less than 8640000000000</p> |
There was a problem hiding this comment.
should use constant that is used in code instead of being hardcoded
| @@ -115,6 +115,10 @@ class SpiffeHelper extends Component { | |||
| // n:1, this would reduce the total cost. This may be useful when | |||
| // performance is impacted. | |||
| getAgentsEntries (agents, entries) { | |||
| if (typeof entries === 'undefined') { | |||
| console.log("spiffe-helper.js: getAgentEntries: this should not happen, entries undefined`") | |||
| //return {}; | |||
There was a problem hiding this comment.
uncomment this return
|
Waiting for TypeScript completion |
|
@mamy-CS to work on this |
mamy-CS
changed the title
3 tasks
|
Merged work on #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving - lumjjb/tornjak-old#96
Editing entry-create form for multiple entry formats and warnings on already expired entries or data that causes no expiry date
Signed-off-by: Maia Iyer maia.raj.iyer@gmail.com