Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workload Entry expiry features [Rebased+Updated Work] #106

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Workload Entry expiry features [Rebased+Updated Work] #106

merged 3 commits into from
Jan 10, 2023

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented Dec 5, 2022

Rebased and updated PR #22
Signed-off-by: Mohammed Abdi moabdi@Mohammeds-MBP-2.attlocal.net

entry expiry features added
651b2be 
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
@mamy-CS mamy-CS self-assigned this Dec 5, 2022
check date validity properly
5ff0f4f 
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
maia-iyer
maia-iyer approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@maia-iyer maia-iyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm! minor nits

would you be able to build the tornjak frontend image and test the build? it seems to not work for me

tornjak-frontend/src/components/entry-create.tsx Outdated Show resolved Hide resolved
tornjak-frontend/src/components/entry-expiry-features.tsx Outdated Show resolved Hide resolved
nits
a6845e8 
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
@mamy-CS mamy-CS merged commit 800a075 into spiffe:main Jan 10, 2023
@maia-iyer maia-iyer linked an issue Feb 8, 2023 that may be closed by this pull request
[Feature] Workload Entry Expiry Time UI Handling #11
Closed
3 tasks
@mamy-CS mamy-CS mentioned this pull request Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maia-iyer maia-iyer maia-iyer approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

Assignees

@mamy-CS mamy-CS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Workload Entry Expiry Time UI Handling
2 participants
@mamy-CS @maia-iyer