DP-35365: Fix image styles in rich text with text wrapping #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,12 @@ $figures-gutter: 20px; | |||
| margin: 10px $figures-gutter 10px $figures-gutter; | |||
| } | |||
|
|
|||
| @media ($bp-x-small-max) { | |||
There was a problem hiding this comment.
Instead of adding a new media query, I wonder if there's any reasons of needing the previous one @media ($bp-x-small-min) to add the margins - the only thing I can think of is when the figure expands the full width on mobile and we want to remove the left-right margins.
|
It looks like the images on mobile got smaller in the backstop report, due to the unwanted margins. It could be related to the previous comment I had #1938 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions
Description
Related Issue / Ticket
Steps to Test
Screenshots
Use something like licecap to capture gifs to demonstrate behaviors.
Additional Notes:
Anything else to add?
Impacted Areas in Application
@todo
Today I learned...