Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-35365: Fix image styles in rich text with text wrapping #1938

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

DP-35365: Fix image styles in rich text with text wrapping #1938

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
46675af
DP-35365: Fix image styles in rich text with text wrapping
arthurbaghdas Nov 20, 2024
2d6237e
DP-35365: Fix image styles in rich text with text wrapping
arthurbaghdas Nov 20, 2024
ee5e4bb
DP-35365: Fix image styles in rich text with text wrapping
arthurbaghdas Nov 20, 2024
e2c3ff5
DP-35365: Fix image styles in rich text with text wrapping
arthurbaghdas Nov 20, 2024
85be81d
fix
arthurbaghdas Dec 2, 2024
358bf4e
Styling fixes
arthurbaghdas Dec 3, 2024
ee0b899
Styling fixes
arthurbaghdas Dec 3, 2024
1901f0c
Merge branch 'develop' into patternlab/DP-35365_fix_image_styles
arthurbaghdas Dec 16, 2024
4a706a9
Mayflower
arthurbaghdas Jan 14, 2025
a18b34e
fix margins
clairesunstudio Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/assets/scss/01-atoms/_figure.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ $figures-gutter: 20px;
margin: 10px $figures-gutter 10px $figures-gutter;
}

@media ($bp-x-small-max) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a new media query, I wonder if there's any reasons of needing the previous one @media ($bp-x-small-min) to add the margins - the only thing I can think of is when the figure expands the full width on mobile and we want to remove the left-right margins.

&.ma__figure-image {
margin: 10px $figures-gutter 10px 0;
}
}

@media ($bp-small-min) {
// support pre-existing figure elements besides dataviz.

Expand Down