-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #4685
base: master
Are you sure you want to change the base?
Develop #4685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 The code meets most of the task requirements, and the issues identified are minor and don't impact the core functionality. Just make sure to address the self-closing <form>
tags and verify the font-weight for future improvements. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<form | ||
action="#" | ||
data-qa="big" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <form>
tag is self-closing, which is not valid in HTML. Forms should have an opening <form>
tag and a closing </form>
tag. Consider changing <form />
to <form>
and ensure it is properly closed with </form>
.
<form | ||
action="#" | ||
data-qa="small" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the previous form, the <form>
tag here is self-closing, which is not valid in HTML. Change <form />
to <form>
and ensure it is properly closed with </form>
.
@font-face { | ||
font-family: Avenir; | ||
src: url(./fonts/Avenir-Book.ttf); | ||
font-weight: 300; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font-weight '300' is used here, which is typically considered a light weight. Ensure that this weight is supported by the font file 'Avenir-Book.ttf'. If not, consider using a more standard weight like 'normal' or 'bold'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
Typical Mistakes
fromBEM
lesson theory are checked.