Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4685

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #4685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe98240
create the task
ochepurna Dec 25, 2024
827659d
add task solution
ochepurna Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ ___

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_search-bar-airbnb/report/html_report/)
- [DEMO LINK](https://ochepurna.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://ochepurna.github.io/layout_search-bar-airbnb/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
36 changes: 26 additions & 10 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,32 @@
/>
</head>
<body>
<input
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
/>
<form
action="#"
data-qa="big"
>
Comment on lines +20 to +23
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <form> tag is self-closing, which is not valid in HTML. Forms should have an opening <form> tag and a closing </form> tag. Consider changing <form /> to <form> and ensure it is properly closed with </form>.

<label>
<input
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
class="form form__big"
/>
</label>
</form>

<input
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
/>
<form
action="#"
data-qa="small"
>
Comment on lines +34 to +37
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous form, the <form> tag here is self-closing, which is not valid in HTML. Change <form /> to <form> and ensure it is properly closed with </form>.

<label>
<input
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
class="form form__small"
/>
</label>
</form>
</body>
</html>
58 changes: 57 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,57 @@
/* add styles here */
@font-face {
font-family: Avenir;
src: url(./fonts/Avenir-Book.ttf);
font-weight: 300;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-weight '300' is used here, which is typically considered a light weight. Ensure that this weight is supported by the font file 'Avenir-Book.ttf'. If not, consider using a more standard weight like 'normal' or 'bold'.


@font-face {
font-family: Avenir;
src: url(./fonts/Avenir-Heavy.ttf);
font-weight: bold;
}

.form {
display: block;
box-sizing: border-box;
width: 100%;
margin-top: 20px;
background-image: url(../src/images/Search.svg);
background-repeat: no-repeat;
border: 1px solid #e1e7ed;
border-radius: 4px;
background-color: #fff;
box-shadow: 0 1px 8px 0 #3d4e611a;
color: #3d4e61;
outline: none;
font-family: Avenir, sans-serif;
}

.form__big {
background-size: 19px;
background-position-x: 26px;
background-position-y: center;
padding-left: 62px;
height: 70px;
font-size: 16px;
line-height: 21.86px;
}

.form__small {
background-size: 11px;
background-position-x: 13px;
background-position-y: center;
padding-left: 33px;
height: 42px;
font-size: 14px;
line-height: 19.12px;
}

.form:hover {
box-shadow: 0 3px 8px 0 #3d4e6133;
}

.form:focus {
box-shadow: 0 4px 4px 0 #00000040;
border: 3px solid #e1e7ed;
font-weight: bold;
}
Loading