Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeding #1316

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feeding #1316

Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,51 @@
# write your code here
class Animal:
def __init__(self, name: str,
appetite: int,
is_hungry: bool = True) -> None:
self.name = name
self.appetite = appetite
self.is_hungry = is_hungry

def print_name(self) -> str:
return f"Hello, I'm {self.name}"
AlyaVKravchenko marked this conversation as resolved.
Show resolved Hide resolved

def feed(self) -> int:
if self.is_hungry:
print(f"Eating {self.appetite} food points...")
self.is_hungry = False
return self.appetite
else:
return 0


class Cat(Animal):
def __init__(self, name: str, appetite: int = 3, is_hungry: bool = True) -> None:
super().__init__(name, appetite, is_hungry)
self.appetite = appetite
self.is_hungry = is_hungry

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appetite and is_hungry attributes are already initialized in the super().__init__ call. You don't need to set them again in the Cat class constructor.


def catch_mouse(self) -> None:
print("The hunt began!")


class Dog(Animal):
def __init__(self, name: str, appetite: int = 7, is_hungry: bool = True) -> None:
super().__init__(name, appetite, is_hungry)
self.appetite = appetite
self.is_hungry = is_hungry

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appetite and is_hungry attributes are already initialized in the super().__init__ call. You don't need to set them again in the Dog class constructor.

def bring_slippers(self) -> None:
print("The slippers delivered!")


def feed_animals(animals: list) -> int:
feed_num = []
for animal in animals:
feed_num.append(animal.feed())
return sum(feed_num)

cat = Cat("Cat", False)
lion = Animal("Lion", 25, True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Cat instance is being initialized with a boolean value False instead of an integer for appetite. This should be an integer value, such as 3.

dog = Dog("Dog")

print(feed_animals([cat, lion, dog]))
Loading