Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Chukhno-Maksym
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Animal class and its subclasses! 🎉 Your code meets the task requirements and constraints effectively. While there are minor suggestions for improvement, such as returning a string in the bring_slippers and catch_mouse methods, these do not impact the core functionality. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +17 to +18
return self.appetite
return 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a logical error here. The feed method should return the appetite only when the animal is hungry and has been fed. When the animal is not hungry, it should return 0. The current implementation correctly returns 0 when the animal is not hungry, so no changes are needed here.

super().__init__(name, appetite=3, is_hungry=is_hungry)

def catch_mouse(self) -> str:
print("The hunt began!")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catch_mouse method in the Cat class should return a string as indicated by its signature. Consider returning a string message after printing.

super().__init__(name, appetite=7, is_hungry=is_hungry)

def bring_slippers(self) -> str:
print("The slippers delivered!")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bring_slippers method in the Dog class should return a string as indicated by its signature. Consider returning a string message after printing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants