Display Additional Info On ClassCard #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianAndersen
force-pushed
the
additional-info-on-class-card
branch
from
2c204b2
to
482f82f
Compare
|
Would be nice to see a little love for this one @mathiazom 😽 |
Might be an unlucky example, but from the image it seems like the additional info is not very interesting. So I'm not sure it deserves the real estate 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have always envisioned the "Annet" category as something reserved for exciting events and special occasions.
Previously, events that had additional info were automatically assigned to the "Annet" category. This worked well for FSC Ski and 3T Fossegrenda (the homies), because they only added additional info on special occasions (pop-up events).
However, other locations (😤) use the additional info as a regular thing. Therefore, the "Annet" category is watered with "boring" normal classes on a lot of locations.
So how can we make the "Annet" category a special unicorn again?
Well, we can display the additional info directly on the ClassCard. That way, we get notified that there is some interesting info about the class, as well as keeping the "Annet" category clean.
Before
After