-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement registering with an email support #1837
Implement registering with an email support #1837
Conversation
…fix CreateSession to be conformant to V1 api
Regarding failing CodeQL checks - for both |
} | ||
util.GetLogger(ctx).Infof("conecting to identity server: %s", cred.IDServer) | ||
url := fmt.Sprintf( | ||
"https://%s/_matrix/identity/api/v1/3pid/getValidated3pid", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dendrite isn't my project, but:
this endpoint is deprecated by MSC2713 and it's likely that sydent will soon drop support for it.
In general, homeservers should not be delegating responsibility for email address validation to identity servers, since it allows a compromised ID server to be used to take over homeserver accounts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for comment. I think I have misunderstood concept of ID server. It makes sense that homeserver sends email on its own. So ID server would be user after registration to publish association, so that other may find user by email, right? I suppose also that auth stage for login should be also done without ID server. I am right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's right.
Closing this as long as we want HS to send validation emails - see this issue. |
Support for registration via email sent by identity server. Resolves #1298, but there is a catch.
Test case
Can register using an email address
validates registration when dendrite itself sends verification email. In this PR dendrite sends/_matrix/identity/v2/validate/email/requestToken
request to identity server (which will trigger sending email). New test case must be implemented in sytest. Proposed name:Can register using an email address via identity server
Allowable authentication flows must be passed via config file. This PR setups following convention (at the same time putting step towards removing
Derived
):What's left to do?
Pull Request Checklist
sytest-whitelist
as specified in docs/sytest.mdSigned-off-by:
Piotr Kozimor <p1996k@gmail.com>